Comments (4)
In this case it's fine though. The buffer size statically cannot be overflowed and C99 snprintf cannot be relied upon due to old msvcrt versions.
Is #pragma warning disables fine here? I'd rather avoid special paths with the "safe" versions for MSVC.
from spirv-cross.
@HansKristian-ARM
Yes, of course
Nobody will ever notice this, if console will not be flooded with warnings :)
from spirv-cross.
Ok, the MSVC build already has the -D_CRT_blabla define, I guess the real problem is when using the source files externally, will just move stuff to the source files instead.
from spirv-cross.
Fixed.
from spirv-cross.
Related Issues (20)
- SPV_KHR_cooperative_matrix GLSL support?
- MSL: Invalid code generated with matrix temporary HOT 3
- OpAtomicSMax behaves as unsigned HOT 2
- MSL: Shader input overrides are not applied for block, array, and struct types HOT 1
- MSL: Casting from float to short/ushort introduces a cast to half in between. HOT 3
- Array wrapper may cause a GPU crash? HOT 6
- MSL: invalid code generated when atan2 and saturate are used in mixed precision environment HOT 1
- Invalid MSL when multiple SPIR-V variables are decorated with the same `BuiltIn` HOT 2
- MSL: how to query bind-point of `[image]_atomic` buffer? HOT 1
- Decompile glsl and get unexpected buffer size HOT 2
- Aliasing of argument buffers on breaks padding in some cases HOT 4
- Tests failures HOT 2
- MSL: Option to enforce fragment execution when side effects are present before discard HOT 1
- MSL: non-const reference cannot bind to vector element when passing a vector component as out parameter HOT 3
- Msl: Texture2D used with SampleCmp is not converted to depth2D in all functions HOT 1
- hlsl: Geometry shader generation produces unsupported execution model exception HOT 5
- MSL: Argument buffer IDs are increased across buffers HOT 2
- Slang produces spv that works on win/linux but not with MoltenVk HOT 5
- MSL: 1-size hack for runtime arrays causes GPU page fault HOT 1
- compiler is optimizing unreferenced parameter in CompilerGLSL::type_to_array_glsl and causing linking issues HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spirv-cross.