Giter Site home page Giter Site logo

Comments (4)

keryell avatar keryell commented on June 30, 2024 1

That is an interesting question.
While it makes sense to test for something expected to work even as deprecated, on the other hand it put some legacy burden on new implementers of SYCL2020 to be conformant.
So, I do not have a clear answer in a world with limited resources on different sides.

from sycl-cts.

psalz avatar psalz commented on June 30, 2024

Why should deprecated APIs be treated any different from regular APIs (by introducing a separate "category")? Other than maybe surrounding them with a #pragma GCC diagnostic ignored "-Wdeprecated-declarations" , I see no reason why they couldn't just live next to the other tests for a particular feature.

Regarding that point, #163 should probably not have removed the tests for .has_extension() , but rather added a separate case for .has().

Edit: Maybe we could introduce helper macros like CTS_SUPPRESS_2020_DEPRECATIONS_START / CTS_SUPPRESS_2020_DEPRECATIONS_STOP to make the reason for ignoring diagnostics more explicit.

from sycl-cts.

fraggamuffin avatar fraggamuffin commented on June 30, 2024

Sept 9:

  • do impl have to impl deprecated feature to be conformant? they do
  • its a warning to user that it could be removed in future
  • introduce way to turn off deprecation warning in CTS seems reasonable
  • have a pragma for conditional compilation or to don't warn about deprecated features
  • OPenCL header has the same feature to remove the warning but its only C API
  • split CTS between deprecated and non-deprecated?
  • We can hide tests for deprecated feature under SYCL_CTS_ENABLE_FULL_CONFORMANCE option.
  • App A3 device info descriptors is still there
  • RK compile list of PR to revert and PK to make adjustments

from sycl-cts.

fraggamuffin avatar fraggamuffin commented on June 30, 2024

not critical
but need control on duplicated features in CTS

from sycl-cts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.