Comments (4)
That is an interesting question.
While it makes sense to test for something expected to work even as deprecated, on the other hand it put some legacy burden on new implementers of SYCL2020 to be conformant.
So, I do not have a clear answer in a world with limited resources on different sides.
from sycl-cts.
Why should deprecated APIs be treated any different from regular APIs (by introducing a separate "category")? Other than maybe surrounding them with a #pragma GCC diagnostic ignored "-Wdeprecated-declarations"
, I see no reason why they couldn't just live next to the other tests for a particular feature.
Regarding that point, #163 should probably not have removed the tests for .has_extension()
, but rather added a separate case for .has()
.
Edit: Maybe we could introduce helper macros like CTS_SUPPRESS_2020_DEPRECATIONS_START
/ CTS_SUPPRESS_2020_DEPRECATIONS_STOP
to make the reason for ignoring diagnostics more explicit.
from sycl-cts.
Sept 9:
- do impl have to impl deprecated feature to be conformant? they do
- its a warning to user that it could be removed in future
- introduce way to turn off deprecation warning in CTS seems reasonable
- have a pragma for conditional compilation or to don't warn about deprecated features
- OPenCL header has the same feature to remove the warning but its only C API
- split CTS between deprecated and non-deprecated?
- We can hide tests for deprecated feature under SYCL_CTS_ENABLE_FULL_CONFORMANCE option.
- App A3 device info descriptors is still there
- RK compile list of PR to revert and PK to make adjustments
from sycl-cts.
not critical
but need control on duplicated features in CTS
from sycl-cts.
Related Issues (20)
- accessor_iterator_requirement.cpp uses virtual functions on device side HOT 2
- Potential bugs in CTS when running with hipSYCL HOT 1
- Math arrays and new function overloads missing from the math built-in api tests HOT 2
- CTS uses type aliases which do not exist in the spec
- [CI] Change host compiler to Clang HOT 2
- Reduce duplicate code in tests for `sycl::item` HOT 2
- Improve ranges and index space identifiers tests HOT 2
- Commit "add tests for common reference semantics" fails CTS compilation on CUDA with DPCPP HOT 2
- Test that CGF is invoked synchronously within same thread as call to `sycl::queue` HOT 1
- Possible errors in `accessor_legacy` tests HOT 2
- Provide prebuild binaries HOT 3
- Using `sycl::half` in functions like `std::floor` is ambiguous HOT 4
- Add check for static constexpr dimensions member to all range/id-like types HOT 3
- Build error on enabling accessor implicit conversion tests HOT 1
- Possible bug in `accessor_legacy` tests HOT 6
- Using ComputeCPP in GitHub Actions CI. HOT 6
- New builtin guarantees should be covered by the builtins tests HOT 2
- Bump hipSYCL version and regenerate filters HOT 3
- `test_vector_operators` does not cover logical and relational operators
- `marray` test does not test everything (or anything?) on device HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sycl-cts.