Comments (7)
@mark-lunarg Probably fixed by 3a548ef
BTW might make sense to close issues in the original repo...
from vulkan-validationlayers.
Comment by chrisforbes (MIGRATED)
Tuesday Mar 21, 2017 at 22:53 GMT
Difficult to do a good job here -- render area isn't included in VkCommandBufferInheritanceInfo, so we're never going to know it in a secondary command buffer at recording time.
Have to defer either to CmdExecuteCommands, or QueueSubmit, like some other recently adjusted checks.
from vulkan-validationlayers.
Comment by karl-lunarg (MIGRATED)
Wednesday Mar 22, 2017 at 18:00 GMT
There's a similar issue in LunarG's LunarXchange (654). Probably exactly the same.
from vulkan-validationlayers.
Comment by phaulos (MIGRATED)
Wednesday Mar 22, 2017 at 18:01 GMT
If possible it would be best to do the check in vkCmdExecuteCommands(). At
that point the primary command buffer has seen vkCmdBeginRenderPass() and
knows the render area. That is also off the critical path, unlike
vkQueueSubmit().
On Wed, Mar 22, 2017 at 10:54 AM Karl Schultz [email protected]
wrote:
There is an issue like this logged in LunarG's LunarXchange (#654).
I got "Vulkan internal report (code 1115): vkCmdClearAttachments(): The
area defined by pRects[0] is not contained in the area of the current
render pass instance."but I'm only recording secondary command buffer, primary command buffer
didn't yet got vkCmdBeginRenderPass! Like in this case:
vkBeginCommandBuffer( vkSecondaryCmdBuffer, &vkCmdBufferBeginInfo);VkClearAttachment vkClear; vkClear.colorAttachment = 0; vkClear.aspectMask
= VK_IMAGE_ASPECT_COLOR_BIT; vkClear.clearValue.color.float32[0] = 0.0;
vkClear.clearValue.color.float32[1] = 0.0;
vkClear.clearValue.color.float32[2] = 0.0;
vkClear.clearValue.color.float32[3] = 0.0; const VkClearRect vkRect = { { {
0,0 },{ 128,128 }, }, 0,1 }; pvkCmdClearAttachments( vkCmdBuffer, 1,
&vkClear, 1, &vkRect);And right here VL reports! It's true that at that time primary command
buffer didn't record begin render pass yet, but I think this report should
be moved to execution of secondary command buffer.It is a new-ish issue and has not been resolved yet.
But in the validation layer code, in PreCallValidateCmdClearAttachments(),
there is:// TODO: This check should be moved to CmdExecuteCommands or
QueueSubmit to cover secondary CB casesChris, do you think that this can/should be resolved by moving the check?
On Tue, Mar 21, 2017 at 4:53 PM, Chris Forbes [email protected]
wrote:Difficult to do a good job here -- render area isn't included in
VkCommandBufferInheritanceInfo, so we're never going to know it in a
secondary command buffer.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<
KhronosGroup/Vulkan-LoaderAndValidationLayers#1601 (comment)
,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/APq0i0o_6ZVK6BMrakh0pfsJW2rPU59uks5roFUEgaJpZM4Misus.
--
Karl Schultz
LunarG
[email protected]—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
KhronosGroup/Vulkan-LoaderAndValidationLayers#1601 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASCSA_Xo6SjshhnPVWU2ffcVVpgyl6pks5roWBsgaJpZM4Misus
.
from vulkan-validationlayers.
Triage notes: see discussion above. First step would be to verify the bug still exists vs. the CTS test case.
from vulkan-validationlayers.
The error doesn't happen in dEQP-VK.api.command_buffers.render_pass_continue
of CTS any longer with Vulkan SDK 1.1.101.0
, and VkPositiveLayerTest.ConfirmNoVLErrorWhenVkCmdClearAttachmentsCalledInSecondaryCB
passes. So should we close the issue?
from vulkan-validationlayers.
@phaulos -- this appears to be resolved, ok to close?
from vulkan-validationlayers.
Related Issues (20)
- Importing opaque external handle fails validation on Windows HOT 2
- Missing Android Binaries for 1.3.275.0 HOT 6
- False positive in sync validation for swapchain image HOT 2
- False positive in sync validation w.r.t. sync2 access flags HOT 2
- False positive sync validation with timeline semaphores HOT 3
- Optionally add new lines to VU output HOT 3
- Fix edge cases for GPU-AV shader instrumentation
- vkUpdateDescriptorSetWithTemplate missing validation on Acceleration structure descriptor information HOT 2
- Incorrect `PRESENT_AFTER_WRITE` after signalling with `ALL_COMMANDS_BIT` HOT 15
- Add VUID-VkCopyAccelerationStructureToMemoryInfoKHR-dst-03561
- `SYNC_FRAGMENT_SHADER_INPUT_ATTACHMENT_READ` being considered outside of a render pass HOT 8
- Remove BUFFER_STATE_PTR
- Option to remove the `seq_no` and `reset_no` from sync val output HOT 1
- Dynamic rendering: missing validation for MSAA HOT 5
- Fix RayTracing test producing extra VU on RADV
- Create GPU-AV Ray Query tests
- Create GPU-AV Ray Tracing tests
- Queue submit synchronization validation asserts/crashes in `GetDebugRegionName()` HOT 6
- Improve GPU-AV bindless descriptor shader instrumentation speed on larger shaders HOT 1
- Shader instrumentation failed on MoltenVK
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vulkan-validationlayers.