Instructions incomplete on Ubuntu 16.04

[kiedanski]

Instructions incomplete on Ubuntu 16.04

[kiedanski]

I think the problem you are having is due to the fact that in Ubuntu 16.04, python3 is actualy 3.5 and 3.6.

I created a docker to reproduce this problem. I'm have no experience with Vagrant, but i believe this should be similar enough.
The new dockerfile is Dockerfile_xenial created in 5241d05

To test it , run:

docker build -f Dockerfile_xenial -t pymarket:xenial .
 docker run -it pymarket:xenial

Once in the console, you can open open python using:

python3

I used one of the examples in the the documentation and it works fine:

import numpy as np
import pandas as pd
import matplotlib.pyplot as plt
import networkx as nx
import pymarket as pm
r = np.random.RandomState(1234)
mar = pm.Market()

mar.accept_bid(1, 6.7, 0, True, 0)
mar.accept_bid(1, 6.6, 1, True, 0)
mar.accept_bid(1, 6.5, 2, True, 0)
mar.accept_bid(1, 6.4, 3, True, 0)
mar.accept_bid(1, 6.3, 4, True, 0)
mar.accept_bid(1, 6, 5, True, 0)

mar.accept_bid(1, 1, 6, False, 0)
mar.accept_bid(1, 2, 7, False, 0)
mar.accept_bid(2, 3, 8, False, 0)
mar.accept_bid(2, 4, 9, False, 0)
mar.accept_bid(1, 6.1, 10, False, 0)

bids = mar.bm.get_df()
transactions, extras = mar.run('p2p', r=r)
stats = mar.statistics()

[taqtiqa-mark]

Steps to reproduce (using a Digital Ocean VM):

push dev/xenial
vagrant up
vagrant provision

Please update the, several, installation sections on various pages to reflect the linux distributions, and releases you have actually verified your installation instructions on.

I've given you a possible pattern for Ubuntu releases. It's up to you how many of these you verify your instructions.

Your instructions should take some one from a clean base to a working pymarket.
Later this will help you with debugging issues by being able to replicate the environment needed to reproduce the bug.

I don't propose to do further development along these lines and leave remaining implementation and documentation to you.
The review process is not for the reviewer's to develop your instructions - but I've got you to the point where you should be able to proceed.

[taqtiqa-mark]

This should not be closed:

1. The output indicates it is a pip issue.
2. The Travis config suggests Ubuntu 16.04 (Xenial) is supported.

[kiedanski]

The docker i uploaded is running with an old version of pip (8) and it works flawlessly:

Python 3.6.8 (default, Oct  9 2019, 14:04:01) 
[GCC 5.4.0 20160609] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> 
KeyboardInterrupt
>>> 

root@bdf6686310c3:/# python3 -m pip --version
pip 8.1.1 from /usr/lib/python3/dist-packages (python 3.6)

If you want me too add a line that says that a recent pip is recommended, I'll do it. But it is a python's version problem.

[taqtiqa-mark]

I just want instructions that anyone can follow and get up and running.

You need to add update pip instructions (see your .travis.yml file) if you want to say Ubuntu Xenial works out if the box.

It shouldn't be necessary to have docker or vagrant to get this running.