Proxy release files through worker

[killeencode]

Proxy release files through worker

[RyKilleen]

Hey @ghostdevv I see Tauri added the requested feature! Does that mean this issue is no longer needed?

[ghostdevv]

Probably not, however it might be good for people who don't wanna ship their gh token in their tauri app

[RyKilleen]

I'm going to close this for now, but open to a new request or PRs!

[ACPixel]

Not to open up an old issue, but if any work is still being done on this I would also love to have a proxy server in here. I'd love to do it myself but cloudflare workers are not my forte. Would be super nice to have this though!

[RyKilleen]

@ACPixel no worries, happy to take a look into it. Does the above describe your needs? is there anything not captured here that should be?

[ACPixel]

I think that the issue contains everything that would need to be there. Basically just a route to proxy the files, and would need to make sure the json responses contain links to the proxy instead of the release files directly.

[RyKilleen]

@ACPixel @ghostdevv This is now merged and available! Proxying is enabled if a GITHUB_TOKEN is set, please let me know how it works out for you!

[ACPixel]

Amazing! I'll try it out as soon as possible! Thanks again for taking and look and a huge thanks for doing that so quickly!

[ACPixel]

Alright got a chance to try it out, everything works as intended except one thing. The actual downloads don't work for private repos as it's trying to proxy the "browser_download_url" which only works via a valid github auth. Adding the auth headers and switching the url from the browser_download_url to the url on the release json fixes this issue as it then uses the release assets API to get the file.

I'm doing it like this since in my case I only need to handle the private github repo:

const getLatestAssets = async (request: Request) => {
  const fileName = request.url.split("/")?.at(-1);
  if (!fileName) {
    throw new Error("Could not get file name from download URL");
  }

  const release = await getLatestRelease(request);
  const downloadPath = release.assets.find(
    ({ name }) => name === fileName,
  )?.url;

  if (!downloadPath) {
    throw new Error("Could not get file path from download URL");
  }

  const { readable, writable } = new TransformStream();
  const headers = new Headers({
    Accept: "application/octet-stream",
    "User-Agent": request.headers.get("User-Agent") as string,
  });

  if (GITHUB_TOKEN?.length)
    headers.set("Authorization", `token ${GITHUB_TOKEN}`);
  const file_response = await fetch(downloadPath, {
    method: "GET",
    redirect: "follow",
    headers,
  });

  file_response?.body?.pipeTo(writable);
  return new Response(readable, file_response);
};

[RyKilleen]

Ah that makes total sense, probably should have set up a private repo to test it fully 😃

Would you mind doing a PR with those changes? Glad you got it working!

[ACPixel]

Yeah can do. I have to clean up a couple things I put in while testing but I'll try to get one out tonight. Also had to update typescript version to get the .at() functions you used working.

[RyKilleen]

@ACPixel I appreciate that, was attempting to do it pretty hastily and the repo definitely could use a little new years cleaning!

[ACPixel]

No problem! Sorry for the delay been a busy week, I'll try to get it cleaned up and ready within the next couple of days haha

[ghostdevv]

Awesome! Managed to get this working today with some tweaks to the code

@ACPixel Did you manage to get some time to look at a PR? Lmk if you need any help