Long labels

[kingaa]

Long labels

[kingaa]

Happy to consider pull requests with documentation changes, as well as additional plotting options. It might also be good to add additional data sets. The primates data you sent earlier is sitting on the repo now, but not included in the package. Not sure if it is a good one.

[kingaa]

One thing to keep in mind in this is that ouch is deficient in unit tests. With each proposed change, it would be good to include tests (in the tests directory) that test the new functionality.

[kingaa]

Getting the width of strings right is complicated: it depends on the font, the specific letters, etc. I looked into it awhile back and came away shaking my head. How about just giving the user an option (say, labelwidth, default = 0.1) which specifies the width of the label panels. A bit of trial-and-error will then get it right.

[mbutler808]

Sure, that would work too!
I would like to update the help pages to provide more examples and explanation. Would you be OK with that? I saw that it is now autogenerated from Roxygen, so I will have to study that first. M

[kingaa]

Using the plotting branch, I can do the following. Is this an improvement? I'm not sure: seems a lot of clunkiness just to adjust label widths.

with(bimac,ouchtree(node,ancestor,time,species)) -> tr
plot(tr)
plot(tr,text_opts=list(cex=1,pos=4))
plot(tr,text_opts=list(cex=0.5,pos=4))

bimac$silly <- ifelse(
  is.na(bimac$species),
  NA_character_,
  "anamagrophilexitudinousityarpificationesqueness"
)

with(bimac,ouchtree(node,ancestor,time,silly)) -> tr
plot(tr,text_opts=list(pos=4))
plot(tr,text_opts=list(cex=0.5,pos=4))

with(bimac,ouchtree(node,ancestor,time/max(time),silly)) -> tr
plot(tr,text_opts=list(pos=4))
plot(tr,text_opts=list(cex=0.5,pos=4))