kingsleykuan/pe

pe's Issues

Missing self-invocation bar in sequence diagram for "How EditBookingCommand interacts with Model to edit the booking"

Sequence diagram for "How EditBookingCommand interacts with Model to edit the booking" is missing a self-invocation bar for createEditedBooking(bookingToEdit, editedBookingDescriptor)

Incorrect notaion in UML diagram for Model: stray filtered list text

There is a filtered list text next to the multiplicity between ModelManager and Residence. This notation is incorrect and it is not clear what this means.

Long tag names are cut off

Long tag names are cut off in the GUI (even resizing the window or scrolling does not help)

Example: add n/test10 a/22 Simei Street 1, #10-02, S529948 t/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaabbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbcccccccccccccccccccccccccccccc

Result:

Severity set to low as it is uncommon that users would want to enter such long tag names. However it is still an inconvenience and there is no limitation specified anywhere in the app or documentation.

Repition of Logic Diagram

Logic diagram is first shown on page 4:

Then again on page 6:

However there was no reason to show it on page 4, making it a duplicate diagram.

Vague requirements in NFR: Not scoped clearly

Point 2 and point 3 of the non functional requirements are not scoped clearly.

In point 2: What is "noticeable sluggishness"?, what is "typical usage"?

In point 3: What is "average typing speed"?

Tags are cut off when too many are added and ability to scroll is not mentioned in the user guide

When adding tags eg: add n/test1 a/22 Simei Street 1, #10-02, S529948 t/tag1 t/tag2 t/tag3, all tags are shown.

However when too many tags are added, tags are with partially cut off or entirely hidden from view.

add n/test3 a/22 Simei Street 1, #10-02, S529948 t/tag1 t/tag2 t/tag3 t/tag4 t/tag5 t/tag6 t/tag7 t/tag8 t/tag9 t/tag10 t/tag11 t/tag12 t/tag13 t/tag14 t/tag15 t/tag16 t/tag17 t/tag18 t/tag19 t/tag20

While the user is able to scroll through the list of tags, this feature is not obvious as it is not mentioned in the user guide and the scrollbar is not very visible.

Typo in NFR: Missing capitalisation

Point 4 of the non functional requirements is not capitalized:

Long residence names are cut off

Long residence names are cut off in the GUI and cannot be seen (even resizing cannot help).

Example: add n/The Great Golden Mirage Way of Excellence a/22 Simei Street 1, #10-02, S529948

Result:

Severity set to medium as it affects users who want to input a long residence name, but they can still otherwise use the application.

Long residence addresses are cut off

Long residence addresses are cut off in the GUI (even resizing does not help)

Example: add n/Pasir Ris Palace a/123 Pasir Ris Drive Street Roundabout 12345, #12-642, S529948

Result:

Severity set to medium as it affects users who want to input long addresses, but otherwise they may still use the application.

Application fails to start JSON file is edited to have an overlapping booking

JSON file was edited to include an overlapping booking.

As a result, the application fails to start and an uncaught exception is thrown:

This contradicts the UG, which states that the application would discard all data

Severity set to high as while it only affects advanced users who edit the JSON file, they are unable to continue using or troubleshoot the app as no error is given other than in the console which is not shown unless launched with java -jar manually, which the user guide does not suggest to do.

No limit to length of phone number

There is no limit to the length of a phone number despite the fact that no such long phone numbers exist.

Example:
addb 2 n/a p/1111111111111111111111111111111111111111111111 s/01-01-2022 e/02-01-2022

Result:

Typo in use case UC01: User validates details

In step 2 of UC01, it is stated that the user validates the details when it should be the system that validates instead. Similarly, the extension 2a only makes sense if it is the system that is validating, not the user.

Typo in user stories

There is a typo in the user stories, should not be "be reminded me of upcoming..."

Application fails to start when cleanStatusTag is modified to an invalid value in JSON file

cleanStatusTag was set to an invalid value in the JSON file: "abc"

Application fails to launch and an uncaught exception is thrown:

This contradicts the UG, which states that the application would discard all data

Severity set to high as while it only affects advanced users who edit the JSON file, they are unable to continue using or troubleshoot the app as no error is given other than in the console which is not shown unless launched with java -jar manually, which the user guide does not suggest to do.