Comments (7)
I think what you are proposing would be a good improvement.
What would be a better improvement would be to remove the limitations so they don't need to me documented - i.e. make p4a support ~=
, <=
and >=
at a minimum.
(At the moment, version information is passed to the recipes via environment variables! Changing that to a more direct method might be a useful refactor too.)
from python-for-android.
By supporting ~=
,<=
, and >=
- do you mean treating them all as ==
? Or implementing a mechanism to see which versions available support the specification?
The first I think is not very good, as it doesn't behave as expected probably. And the latter would mean more complication, possibly slower runtime, and if each package has its own requirements with different version - a dependency hell like can happen in pip, resulting in spending a lot of time trying to get everything to play well together,
Also, in the recipes, I don't see a version for the packages each recipe depends on, in another sense it just says "all of these packages work with all of the other packages in the current (latest) state", or am I missing something?
from python-for-android.
I definitely meant the latter. I hadn't considered the dependency hell issue - I guess I hoped it was delegated to pip to sort out.
[I pass on the second question - I don't know the answer.]
from python-for-android.
Seeing as many recipes have a .patch
file, which depends on the code's content (and thus, its version) - I'd assume that the statement in the second question is true.
It may not be defined that way, but if a package changes the patch may not work, so each package has theoretically one supported version at a time.
And if that's the case, perhaps even ==
is not truly valid...
This is getting a bit complicated I believe.
How do you suggest we take it forward @Julian-O?
On an unrelated note - do you know when my PR might be reviewed?
from python-for-android.
@UriyaHarpeness : I wouldn't pin the success of this on my knowledge. I have never written a recipe.
I have idly thought before that recipes need to be totally refactored. They should be subclasses, not modules with weird, poorly documented assumptions. They should provide much more meta-data about what they are expecting, including versions that they are known to work with, versions they are assumed to work with and versions they are known not to work with.
They currently support two platforms (Darwin and Linux), but they should support more.
However, I am not expecting anything in that direction any time soon.
In the meantime, I think your original proposal would still be a step forward.
I have not got code review privileges (a state of affairs I think is very appropriate!) and I can't comment officially on when your PR might be reviewed. I know the core developer(s) are currently focussed on upcoming releases, so I would give it a couple of weeks before I started to ask for more attention.
from python-for-android.
Just to be sure - original proposal meaning the 3 steps I wrote in the issue's description?
from python-for-android.
Yes
If we can't handle the functionality a developer would expect, we should document it and (if we can) detect it and give a meaningful error.
from python-for-android.
Related Issues (20)
- Recipe for SpaCy HOT 1
- com.android.build.gradle.internal.tasks.CompressAssetsWorkAction: Java heap space HOT 1
- How to build a pyside6 project into an apk HOT 1
- push notification for android? need permission ACTION_APP_NOTIFICATION_SETTINGS HOT 2
- Didn't find class "org.kivy.android.PythonActivity$PermissionsCallback" HOT 1
- Questions about Copilot + Open Source Software Hierarchy
- Reportlab recipe HOT 2
- ask HOT 1
- please add uvloop to recipes! HOT 1
- Recipe for mediapipe required to execute python code on android HOT 3
- OpenJDK 11 incompatibility beacuse of Gradle 8.x / cannot build apk on WSL v1 HOT 4
- Add a recipe for `orjson` HOT 3
- Mock assertion issue with ICU recipe under Python 3.12 HOT 3
- Fix screen orientation of PythonActivity.java
- Add the recipe for jsonrpcserver module
- #error "LONG_BIT definition appears wrong for platform (bad gcc/glibc config?)."
- error: command '/home/lumina/.buildozer/android/platform/android-ndk-r25b/toolchains/llvm/prebuilt/linux-x86_64/bin/clang' failed with exit code 1 HOT 2
- Add the recipe for yt-dlp module
- Add recipe `pyreqwest_impersonate` HOT 27
- :rocket: Action plan for hosting prebuilt wheels
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from python-for-android.