Giter Site home page Giter Site logo

Comments (8)

kizitonwose avatar kizitonwose commented on June 19, 2024 1

FYI: In version 2.6.0, I will remove desugar requirement from the library (while keeping the current min sdk). All the calendar logic live in the core and data modules which are pure java/kotlin modules hence no need for desugar there. I have also seen that I can remove the requirement from the view and compose library modules as well, without changes to the min sdk.

There is already a snapshot published with this feature if you'd like to test that everything works as expected:

repositories {
    google()
    mavenCentral()
    // Add the snapshot repository
    maven("https://s01.oss.sonatype.org/content/repositories/snapshots/")
}

dependencies {
    implementation("com.kizitonwose.calendar:view:2.6.0-SNAPSHOT")
    implementation("com.kizitonwose.calendar:compose:2.6.0-SNAPSHOT")  
}

from calendar.

kizitonwose avatar kizitonwose commented on June 19, 2024

Most things can be done using the Kotlin standard library and avoiding using JDK apis that require core library desugaring.

This may be true, but the java.time APIs are much easier to work with. No point reinventing the wheel which will end up making the library usage even more difficult because you have to figure out how to do everything with the standard library. The increased build time is a small price IMO.

from calendar.

yogurtearl avatar yogurtearl commented on June 19, 2024

Thoughts on making this library minSdk=26, which would allow using java.time without core library desugaring?

from calendar.

kizitonwose avatar kizitonwose commented on June 19, 2024

I also use this in some projects, and they are all minSdk=24, I would not bump the min sdk for the sole purpose of dropping desugar. In the future, I'd consider splitting it into a separate module, but it is not a priority right now.

from calendar.

el1t avatar el1t commented on June 19, 2024

The latest 2.6.0-SNAPSHOT worked for me without enabling coreLibraryDesugaringEnabled true (minSdk 34), thanks for the fix! Tested with compose compiler gradle plugin 2.0.0 on compose-bom:2024.05.00. I was getting build failures with com.kizitonwose.calendar:compose:2.5.1 and com.kizitonwose.calendar:compose:2.6.0-beta01.

from calendar.

MarcLFJ avatar MarcLFJ commented on June 19, 2024

@kizitonwose Any timeline/estimate for a beta/stable release with not desugar requirement? :)

from calendar.

kizitonwose avatar kizitonwose commented on June 19, 2024

@MarcLFJ I was thinking to release it in version 2.6.0 with Compose UI 1.7, so I don't have to do a version bump twice. But maybe it makes sense to release it already.

from calendar.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.