Giter Site home page Giter Site logo

Comments (9)

nikolaigeorgie avatar nikolaigeorgie commented on August 16, 2024 2

can't we just add <key>UIUserInterfaceStyle</key> <string>Light</string> to the info.plist of this project?

from react-native-rate.

KjellConnelly avatar KjellConnelly commented on August 16, 2024

I'm guessing this is iOS13 bug behavior (maybe dark mode problems) since this module accesses the native APIs. Don't have time to get into it now, and still using iOS 12 currently.

https://stackoverflow.com/questions/57763132/skstorekitreviewcontroller-and-darkmode

I found this on SO. Possible solution is to change BG color of your app while waiting for review to open. If it's my module's problem, and not Apple's, let me know.

from react-native-rate.

patrickxkim avatar patrickxkim commented on August 16, 2024

not sure its a ios13 only issue. I've tried it on a phone not on dark mode, same thing.

I do believe its a Apple issue with the SKStoreReviewController and not yours, but I just wanted to see if others were experiencing this too. The bg color of my app has no bearing on the pop up that is used.

from react-native-rate.

ElieMyIdea avatar ElieMyIdea commented on August 16, 2024

Hi,

I'm having the same issue on IOS 13.1.2 (it was working well on ios 12)

It seems to be related to dark mode

from react-native-rate.

KjellConnelly avatar KjellConnelly commented on August 16, 2024

According to someone from SO: "This issue was resolved in iOS 13.2. The blur effect is dark, just like other system alerts when Dark Mode is enabled."

from react-native-rate.

gusgard avatar gusgard commented on August 16, 2024

I'm using the latest version and we are having this problem (with light and dark mode)

review-app.mp4

We are also using <key>UIUserInterfaceStyle</key> <string>Light</string>, does anyone knows if it is related to this library?

from react-native-rate.

KjellConnelly avatar KjellConnelly commented on August 16, 2024

Hi @gusgard ,

Although this is a similar problem, I believe it is different. The original problem was that the initial pop up was off color. In your video, it seems just the body of the text input is incorrectly colored.

This is an Apple issue, as third party developers have no access to modifying anything after the initial pop up, and before all is dismissed. I'd suggest looking for this topic outside of the react native module/community as it may be another bug on Apple's end that others have spotted.

You can try removing that key. I wouldn't be surprised if it was the problem.

from react-native-rate.

gusgard avatar gusgard commented on August 16, 2024

@KjellConnelly thanks for your feedback 👍

from react-native-rate.

gusgard avatar gusgard commented on August 16, 2024

Might or might not be related to this github issue but this https://developer.apple.com/forums/thread/127787 help me to fix the issue I was having with the Apple review component

if #available(iOS 13.0, *) {
--
overrideUserInterfaceStyle = .light
}

from react-native-rate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.