Comments (10)
Hi,
Indeed, EllipticalMirrorParam
did not allow the top part. I have added a new parameter isClosed
, see here, that controls this behavior.
We have another class for ellipsoidal closed shape, EllipsoidCapillaryMirror
.
The two classes differ in the meaning of center
and pitch
parameters, as explained in the docs, but they give the same result.
Both classes are exemplified in a new test script tests/raycing/test_ellipsoid_tube_mirror.py
.
Please update from GH.
from xrt.
Thanks for the update.
After copy the new oes.py, I can see isClosed as a parameter for xrt.backends.raycing.oes.EllipticalMirrorParam in XRTQook's document part, but it's not in the beamline pane after EllipticalMirror added. Do I miss more files?
from xrt.
Thank you for testing it also with xrtQook! This is fixed now.
from xrt.
Thanks for the update. Now the ray tracing works as expected.
It would be more beneficial if xrtQook can show the entire closed rotation optic surface.
from xrt.
This is fixed now, please try again.
from xrt.
from xrt.
Please go to tests/raycing/test_ellipsoid_tube_mirror.py
, make showIn3D = True
in it and run it. Do you see the mirror surface as a circle? You can make tubeLengtgh = 10000
to better see the ellipsoid.
from xrt.
In xrtQook after I changed the EllipticalMirrorParam shape from "round" to "rect" , the optic closed surface shows correctly. Not sure why "rect" is a right choice. I also tried "None", but the beamline propagation can't complete.
tests/raycing/test_ellipsoid_tube_mirror.py also works to show the surface circle when showIn3D = True
Thanks a lot for your help.
from xrt.
The "round" shape makes a disk (or a coin), which makes no sense for a closed shape like a capillary. I've now modified xrtGlow to ignore this combination and updated the docstrings. You don't have to update, just don't use "round".
Thank you for spotting this corner case.
from xrt.
Thanks.
from xrt.
Related Issues (20)
- How to add a caliber setting!
- Some doubts about the energy setting of X-ray sources HOT 18
- Absorbing wall along the beam propagation direction?
- Help needed! Clarification on the Meaning and Origin of eAxesFlat Values in 07_AnalyzerBent2D.py HOT 2
- Rocking curve theta and energy range converter HOT 3
- Problems generating code from materials HOT 7
- Calculating crystal reflectivity without constructing a beamline HOT 7
- Question about toroidally bent crystal in Laue geometry HOT 6
- VLS grating local_g direction HOT 2
- Regarding the size of light sources and the output of light source images
- How to add and use compound refractive index materials? HOT 9
- The light source image does not match the image at the detector
- Problem when using pytte and OpenCL for bent asymmetric Laue crystal HOT 2
- Passing in_plane_rotation parameter to pytte
- Question about making dispersion plots HOT 1
- Report an error when set useTT is true for using elastic deformation in crystal reflectivity HOT 6
- Saving histogram data HOT 3
- GPU calculation for geometric sources HOT 1
- adding surface error on Ellipsoidal mirror HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from xrt.