build ellipsoidal mirror

[leahwang1962]

build ellipsoidal mirror

[kklmn]

Hi,

Indeed, EllipticalMirrorParam did not allow the top part. I have added a new parameter isClosed, see here, that controls this behavior.

We have another class for ellipsoidal closed shape, EllipsoidCapillaryMirror.

The two classes differ in the meaning of center and pitch parameters, as explained in the docs, but they give the same result.

Both classes are exemplified in a new test script tests/raycing/test_ellipsoid_tube_mirror.py.

Please update from GH.

[leahwang1962]

Thanks for the update.
After copy the new oes.py, I can see isClosed as a parameter for xrt.backends.raycing.oes.EllipticalMirrorParam in XRTQook's document part, but it's not in the beamline pane after EllipticalMirror added. Do I miss more files?

[kklmn]

Thank you for testing it also with xrtQook! This is fixed now.

[leahwang1962]

Thanks for the update. Now the ray tracing works as expected.
It would be more beneficial if xrtQook can show the entire closed rotation optic surface.

[kklmn]

This is fixed now, please try again.

[leahwang1962]

Now the surface very strange.

[kklmn]

Please go to tests/raycing/test_ellipsoid_tube_mirror.py, make showIn3D = True in it and run it. Do you see the mirror surface as a circle? You can make tubeLengtgh = 10000 to better see the ellipsoid.

[leahwang1962]

In xrtQook after I changed the EllipticalMirrorParam shape from "round" to "rect" , the optic closed surface shows correctly. Not sure why "rect" is a right choice. I also tried "None", but the beamline propagation can't complete.
tests/raycing/test_ellipsoid_tube_mirror.py also works to show the surface circle when showIn3D = True
Thanks a lot for your help.

[kklmn]

The "round" shape makes a disk (or a coin), which makes no sense for a closed shape like a capillary. I've now modified xrtGlow to ignore this combination and updated the docstrings. You don't have to update, just don't use "round".
Thank you for spotting this corner case.

[leahwang1962]

Thanks.