Giter Site home page Giter Site logo

Comments (1)

kkomelin avatar kkomelin commented on June 2, 2024 1

Hi @marcesdan ,

Thank you very much for such a thoughtful request and sorry for causing issues with your build pipelines!

I totally agree that the SemVer approach would be very nice to follow but let me quote our readme:

Please note that DOMPurify library doesn't follow Semantic Versioning, so we have to release every change as a minor version because we cannot be 100% sure whether new features are added to patch DOMPurify releases or not.

In this particular case, it was not dompurify library itself, it was its peer-dependency jsdom that switched to Node 18, so I should have released isomorphic-dompurify as a major version. Node 16 is not supported anymore, so I assumed that it would be relatively safe change but I will be more careful in the future.

To sum up, I cannot guarantee following SemVer approach because it doesn't depend on me but I have added the engines field to package.json to help preventing the situation which you experienced in the future.

from isomorphic-dompurify.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.