Giter Site home page Giter Site logo

Comments (7)

epiqueras avatar epiqueras commented on July 20, 2024

Why is currency a prop instead of defaulting to ETH and having a prop token for custom addresses?

from escrow-react.

satello avatar satello commented on July 20, 2024

You can do it this way. You need the ticker as well for display, but you can have token = {ticker, address}

from escrow-react.

epiqueras avatar epiqueras commented on July 20, 2024

You can get the ticker from the token contract.

from escrow-react.

satello avatar satello commented on July 20, 2024

Not always. It is an optional field so I think it is better to have it passed. We also we need to be careful because you can't use any token -- it needs to be ERC20. So if someone uses the widget with a different token the buyers payment will be stuck in the contract. This was my original thinking when I planned to integrate the T2CR.

from escrow-react.

epiqueras avatar epiqueras commented on July 20, 2024

Ahh, ok.

So if someone uses the widget with a different token the buyers payment will be stuck in the contract.

How is that related to the ticker thing?

from escrow-react.

satello avatar satello commented on July 20, 2024

It's related because its part of the decision to not use the T2CR. One option that I was planning on going with is to have them just pass the ticker and look up the contract address in the T2CR (and throw an error if a ticker passed doesn't have the ERC20 badge). The other option we have discussed here is to have the integrator pass the ticker and address

from escrow-react.

epiqueras avatar epiqueras commented on July 20, 2024

Can't multiple tokens have the same ticker?

from escrow-react.

Related Issues (9)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.