Giter Site home page Giter Site logo

Comments (5)

kliment avatar kliment commented on July 20, 2024 1

The other way to reformat it would be a bunch of dictionaries. It might actually be a better use case for readability. We'd then have one dictionary per platform.

from printrun.

neofelis2X avatar neofelis2X commented on July 20, 2024 1

Damn, that’s true. But I have already rewritten the whole function with a dictionary. I realised that it’s not a very elegant approach.
It’s in one of my branches, but I can also push it as a separate PR if you prefer that.

We'd then have one dictionary per platform.

That’s almost exactly what I did in the new version. 😅

from printrun.

neofelis2X avatar neofelis2X commented on July 20, 2024 1

Yes I have the rewritten function as part of a PR that I will push as soon as it’s completed and tested. sorry for the confusion!

from printrun.

kliment avatar kliment commented on July 20, 2024

If that's the only place it's used, I think reworking it to be a bunch of elifs is reasonable.

from printrun.

rockstorm101 avatar rockstorm101 commented on July 20, 2024

It’s in one of my branches, but I can also push it as a separate PR if you prefer that.

Hi @neofelis2X I'm not sure I understand 100% what you mean here sorry. If you were going to submit the rewritten function as part of a bigger PR, then that's OK with me, it can wait. If you weren't going to submit it but happen to have that function already rewritten, then yes please send a PR with the "fix" :)

from printrun.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.