Comments (5)
The other way to reformat it would be a bunch of dictionaries. It might actually be a better use case for readability. We'd then have one dictionary per platform.
from printrun.
Damn, that’s true. But I have already rewritten the whole function with a dictionary. I realised that it’s not a very elegant approach.
It’s in one of my branches, but I can also push it as a separate PR if you prefer that.
We'd then have one dictionary per platform.
That’s almost exactly what I did in the new version.
from printrun.
Yes I have the rewritten function as part of a PR that I will push as soon as it’s completed and tested. sorry for the confusion!
from printrun.
If that's the only place it's used, I think reworking it to be a bunch of elif
s is reasonable.
from printrun.
It’s in one of my branches, but I can also push it as a separate PR if you prefer that.
Hi @neofelis2X I'm not sure I understand 100% what you mean here sorry. If you were going to submit the rewritten function as part of a bigger PR, then that's OK with me, it can wait. If you weren't going to submit it but happen to have that function already rewritten, then yes please send a PR with the "fix" :)
from printrun.
Related Issues (20)
- Unable to run on OSX Ventura (13.2.1) HOT 1
- Exchange of module pyreadline with pyreadline3 in requirements.txt HOT 3
- Pronsole should not load custom button definitions from config file during start
- Can't open pronterface.exe error HOT 2
- Current build procedure does not compile translations
- Pronterface won't launch, AttributeError: 'NoneType' object has no attribute 'write' HOT 3
- Issue with firmware 3.12.2: Line Number is not Last Line Number+1 HOT 8
- Application won't run HOT 4
- Unhandled exception in script HOT 10
- unhandled exception HOT 8
- Failed to execute script 'pronterface' due to unhandled exception: C++ assertion HOT 6
- Mac OS Ventura not compatible HOT 1
- MacOS Ventura MacBook Pro M2 printer won't launch after custom button added HOT 4
- MacOS Ventura MacBook Pro : Can't install Printrun on HOT 4
- My future involvement in Printrun HOT 1
- Deprecation of disutils module HOT 2
- Can not get Printrun (Pronterface) to run on the latest Umbuntu 21.1 HOT 4
- Projector: TypeError on loading SVG HOT 2
- Issue with 2010 MacBook and PronterFace HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from printrun.