Comments (9)
Hi @lutherism . I might be misunderstanding, but wouldn't the current cancel
and success
event handlers be sufficient to close the shadow frame in? They are invoked when the modal is closed.
In addition, if you are calling choose()
via JS, you can open the shadow frame before/after the call. If you are using choosify
, just set a click handler on the element passed in to choosify
to open the shadow frame instead.
Does this work?
from file-picker.
Thanks for the quick response :D.
Do you have a link to the 'close' event? There doesn't seem to be a 'close' event. We have put our UI cleanup in three events: 'cancel', 'success', and 'error', to cover all the close states we could find.
from file-picker.
Apologies I meant cancel
instead of close
. Edited my post above to reflect the correction. That is correct that there are three events you would want to catch to do cleanup in. I'll look into adding a separate close
event to always trigger regardless of the reason for closing.
from file-picker.
Thanks. Yea adding that consistent event will make our code a lot easier to maintain.
from file-picker.
As for the choose hook, you're right it's not as necessary. But it would allow us to be less concerned with when/where we call explorer.choose();
IE, a page could create an explorer instance, then any number of subviews could call explorer.choose() without having to know the specifics of what the page wants to do in response.
from file-picker.
Whoops, accidentally closed. I always mistake that button for the Cancel button.
Adding open
, close
events.
from file-picker.
Added in 3a70c56. This will be released within the week.
from file-picker.
Brilliant. Thanks.
from file-picker.
This has been released.
from file-picker.
Related Issues (20)
- CASHOUT
- React Chooser onDeleteAccount event does not return accountId as specified in the docs HOT 3
- How to see 'connected accounts' ? HOT 1
- Is persistent file access supported? HOT 1
- Do/will you support "Save" instead of "Save as..."? HOT 9
- Can I save a file using a base-64-encoded data URL? HOT 3
- Chrome console showing an error 404 HOT 5
- bearer_token is never set, APIKey works HOT 1
- Breadcrumbs are not aligned when width is constrained in Safari HOT 1
- Explorer default to My Computer HOT 3
- Storj.io gateway integration HOT 3
- Cancel cancel causes upload HOT 2
- Not receiving bearer_token from file chooser HOT 2
- jquery.ui.plupload.js contains an unprintable character HOT 2
- console logging HOT 4
- TypeScript type definitions HOT 1
- Uncaught type error after adding files for upload HOT 3
- Using `multiselect: false` still shows multiple file selection dialog HOT 3
- Cancel button transmogrified following upload in Safari HOT 2
- Dropzone allows dropping wrong file types HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from file-picker.