Comments (5)
You mean that the controller to create from Gateway API from KIngress, correct? If so, we will not create it.
Here is the discussion thread (as you might know) - https://knative.slack.com/archives/CA9RHBGJX/p1613698271156800
- phase-1. Create new networking conformance suite by Gateway API resources.
- phase-2. Create
makeIngressv2()
in serving code. (I think we should allow users to choose KIngress or Ingress v2 by some option during this migration phase.) - phase-3. Deprecate
makeIngress()
in serving code.
from net-gateway-api.
I read the thread again. sounds like we don't need the ingress v2 controller.
Then about the phases, here is what I read from the chat thread:
- Phase 1: Create makeIngressv2() in knative serving code with a feature flag
- Phase 2: testing serving E2E tests with makeIngressv2() enabled for all impls as extra references
- Phase 3: deprecate makeIngress
I am not very sure what we plan to do about "Create new networking conformance suite by Gateway API resources" mentioned in above comment. Do we plan to add conformance test suites within net-ingressv2 to cover all kingress scenarios, or only basic test suites like https://github.com/knative-sandbox/net-ingressv2/pull/10/files#diff-dd6583ae8832b447f778694426e7a1a3f9da8de2ce0991ebfaad75935c87d6d5 for basic sanity check? Could we just skip this phase considering that we may want to run all E2E tests with makeIngressv2 enabled for all impls?
from net-gateway-api.
Thought about this again. I think the value of the work Create new networking conformance suite by Gateway API resources.
is to provide various impls the handy conformance check for the ingress v2 to support knative. So if the work could be landed more easily and quickly, I think we can start with this one.
from net-gateway-api.
Yes, not only handy conformance check for the ingress v2 providers, but also serving's e2e tests do not cover all networking features so we need the "Create new networking conformance suite by Gateway API resources" which can cover current KIngress tests by ingress v2.
Also, we plan to add all conformance tests. I just added basic test only here #10 because creating all test suites needs "man-power". I think I just add a basic test and common utils in #10, then will ask some volunteers to add other tests.
from net-gateway-api.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
from net-gateway-api.
Related Issues (20)
- Bump min k8s version to v1.27
- Generate HTTPRoute sectionName to select listener HOT 2
- Drop replace block
- Create an opinionated Gateway Conformance Test HOT 2
- Bump Contour
- Bump e2e cluster version to 1.28
- Contour External has ExternalName Services Support HOT 4
- Contour continuous tests are pretty flakey HOT 1
- Probing shouldn't be implementation specific
- Not all Gateways have a local K8s Service HOT 2
- Contour continuous tests are flakey HOT 1
- Find a generic way for matching the port by the endpoint lister instead of port name HOT 1
- Update to Gateway v1 APIs HOT 1
- allow custom ports to be probed when gateway-config.visibility does not provide a Service
- net-gateway-api doesn't validate config-gateway HOT 1
- controller should track Gateway and trigger re-reconcile of Ingress
- Failed Contour Gateway Test - GKE issue HOT 3
- Contour is not disabling timeouts HOT 1
- [cilium] ExternalName Service Causes Unintended External Traffic HOT 6
- [cilium] It is not accessible unless helloworld-go-00001.default.svc.cluster.local HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from net-gateway-api.