Investigate and use Istio 1.6 CRD Status

[tcnghia]

Investigate and use Istio 1.6 CRD Status

[markusthoemmes]

@nak3 thanks for bringing that up but I don't think it'd need to be taken into account here. We kinda need a different design downstream to make that work "properly".

[tcnghia]

cc @ZhiminXiang @JRBANCEL @nak3 @therealmitchconnors

[tcnghia]

BTW, for backward compatibility with more Istio versions, and this being alpha feature we will probably need to have a feature flag to turn this on.

[nak3]

It would be easier to implement this to use VirtualService status only, but it would be great if we can use other CRD's status as pluggable.

For example, Knative on OpenShift uses another CRD(OpenShift Route) as a frontend LB and we want to make sure the OpenShift Route's status before Ksvc ready.

FYI @markusthoemmes

[JRBANCEL]

/assign

[JRBANCEL]

It would be easier to implement this to use VirtualService status only, but it would be great if we can use other CRD's status as pluggable.

For example, Knative on OpenShift uses another CRD(OpenShift Route) as a frontend LB and we want to make sure the OpenShift Route's status before Ksvc ready.

I am not sure I understand. In your example, a custom Controller is used (to manage the OpenShift Route), right?
In this case, why does it matter what we do in this repo, specific to Istio?

Anyway, this is blocked because Istio 1.6 populates the status field dynamically and the VirtualService struct doesn't have the field so our generated clients can't consume it cleanly.

@therealmitchconnors what is the issue tracking the work to add the field in 1.7?

[JRBANCEL]

We are doing this with Istio 1.7.1.
/assign @arturenault

[knative-prow-robot]

@JRBANCEL: GitHub didn't allow me to assign the following users: arturenault.

Note that only knative-sandbox members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

We are doing this with Istio 1.7.1.
/assign @arturenault

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[arturenault]

/assign

[arturenault]

Istio doesn't have an ObservedGeneration so we have no way of knowing if the Status is current (i.e. if it has applied our latest changes).

This is being tracked in istio/istio#28003. They're attempting to rush it into 1.8 which closes next week, but if not this might need to wait until Istio 1.9.

[arturenault]

/unassign JRBANCEL

this is confusing the google github sync