Comments (9)
I want to work on this but i am already working on knative-kafka-broker repo issue so after finishing that i would love to work on this if its ok then please let me know.
from client.
Thanks! It's totally fine if you want to jump on this issue later, and we can then work on a PR as soon as you have something to share.
from client.
+1 @rhuss
Assigning to you @Rahul-Kumar-prog to indicate it's being looked at some point. It's still ~2 months until next release v1.12. There's no time pressure right now. Feel free to proceed at your convenience.
/assign @Rahul-Kumar-prog
from client.
I want to work on this issue, can you please tell from where i can start?
from client.
@taniaduggal, that is great! Before we start, I would like to discuss this update's background briefly.
I think this story is part of a larger story, where we allow user to filter out certain information when doing an export so that it can be later used in a GitOps scenario.
Besides the securityContext, I can also see fields we should not export by default, e.g. the namespace.
So I suggest that we make a new option flexible so that we can fine granularly specify what to include (if excluded by default) and what to included (if included by default).
My suggestion would be to have an option like
kn service export myservice --include securityContext,namespace
or
kn service export myservice --include securityContext --include namespace
@dsimansk what is your take on this ?
(using multiple options here).
@taniaduggal for starting its best to look at https://github.com/knative/client/blob/main/pkg/kn/commands/service/export.go which has all the logic for an export. This would be the place where we would evaluate that option and do the filtering.
Thanks again @taniaduggal that you want to jump on the train, greatly appreciated!
from client.
@rhuss I read you idea and you want that users can filter certain info... that good idea.
I have some questions:
like: why we should not use
kn service export <ksvc> --with-securityContext
or
kn service export <ksvc> --with-sc
from client.
@Rahul-Kumar-prog I'd go with @rhuss's suggestion, the --include
flag might be more flexible in the term of adding new known variables, instread of adding the whole new flag, with near infinite growth (hopefully not).
I'd go with this variant. And the valid values are predefined and listed in the help message.
kn service export myservice --include securityContext,namespace
from client.
+1 for not use options inflationary but have an easy way to extend this feature without changing the "option API surface". In addition to provide the options as a comma separated list, multiple --include
options should also work, like in --include securityContext --include namespace
(it then also easy to add shortcuts like --include sc,ns
without blowing up the options)
from client.
Ok, @rhuss @dsimansk
I got your points and rhuss suggestion is perfect to go with.
Is there anything else I need to know?
from client.
Related Issues (20)
- Add `--scale-activation` flag to match new Serving option HOT 5
- Option to specify Node Selector HOT 2
- support uninstallation of local cluster using kn HOT 6
- Compile errors with Go 1.20 HOT 2
- kn does not show new trigger filters HOT 2
- Missing example of fully qualified GVR in`--sink` flag HOT 3
- Eventing TLS: support Eventing TLS in kn-plugin-event HOT 5
- `kn trigger update --help` information is incorrect HOT 2
- CLI: Add support for EventType v1beta2 HOT 6
- CLI: add support for experimental new filters API in trigger HOT 4
- Ability to set toleration, affinity and node selector HOT 8
- 48h Knative - A Hackathon-Style Event
- Remove deprecated `--inject-broker` flag from `trigger` cmds HOT 1
- Upgrade deprecated v1alpha1 DomainMapping API to newer one HOT 5
- Distinguish missing Serving/Eventing API from unsupported version HOT 8
- Fix shellcheck warnings in hack/build.sh script HOT 1
- Update plugin development docs HOT 5
- Can not get my broker through `kn broker list` HOT 6
- [48h Knative] KServe plugin HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.