Comments (8)
@itsmurugappan sorry for the late reply, but this sounds like a good strategy. I don't think you have to implement every method, only those that are needed for this functionality. Also the file name should then be part of that new implementation's struct.
Also I learned this trick today (thanks to @markusthoemmes ):
If you have a big interface to implement but only call a few functions, you can define the struct like this:
type mock struct {
my.Interface
}
It'll implement all functions with nil-pointer function calls. Then you only have to implement the functions your test actually calls
This might be helpful if you only need to instgal some of the methods (like service create or update)
from client.
Considerations:
- Downloading the right objects from etcd to a directory for the first time may another gitops usecase.
- Anything that reads status and uses that information becomes harder or impossible (ex, locking revisions to a container digest)
- Keeping only the "interesting" fields might make the directory easier to use.
from client.
Let's have a mode where you can provide a directory instead of a server to connect to
im somewhat skeptical that this would be that useful if users are using gitops workflow (== more familiar with yamls). what commands do you think will benefit from this?
from client.
throwing this here since it was discussed during today's call:
knative yaml generator
https://github.com/julz/knightrider
from client.
This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen
. Mark the issue as
fresh by adding the comment /remove-lifecycle stale
.
from client.
/remove-lifecycle stale
/assign
from client.
@rhuss @navidshaikh i think this is the issue we discussed in the last wg. For implementing this am planning to take the below approach, please let me know if this is good
- Implement knclientinterface to work on local directory
- change this line in all commands to return the appropriate client based on cmd flags
client, err := p.NewServingClient(namespace)
from client.
(sorry closed by accident)
from client.
Related Issues (20)
- Ability to set toleration, affinity and node selector HOT 8
- 48h Knative - A Hackathon-Style Event
- Remove deprecated `--inject-broker` flag from `trigger` cmds HOT 1
- Upgrade deprecated v1alpha1 DomainMapping API to newer one HOT 5
- Distinguish missing Serving/Eventing API from unsupported version HOT 8
- Fix shellcheck warnings in hack/build.sh script HOT 1
- Update plugin development docs HOT 5
- Can not get my broker through `kn broker list` HOT 6
- [48h Knative] KServe plugin HOT 4
- Align GVK format accepted by `--channel` flag HOT 12
- Flaky E2E test: e2e/TestDomain - create domain with TLS HOT 9
- Wrong version for kn create kafka channel HOT 7
- Add integration tests for all command usage examples in the binary HOT 5
- [48h Knative] Annotation and Label profiles HOT 1
- [48h Knative] Color output HOT 3
- [48h Knative] UX Evaluation HOT 9
- [48h Knative] Kamelet Sinks HOT 2
- [48h Knative] Command Usage Example Integration Testing POC HOT 3
- [48h Knative] Improved Logging HOT 7
- [48h Knative] Good first issues HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from client.