Giter Site home page Giter Site logo

Gitops mode about client HOT 8 CLOSED

knative avatar knative commented on July 21, 2024 1
Gitops mode

from client.

Comments (8)

rhuss avatar rhuss commented on July 21, 2024 2

@itsmurugappan sorry for the late reply, but this sounds like a good strategy. I don't think you have to implement every method, only those that are needed for this functionality. Also the file name should then be part of that new implementation's struct.

Also I learned this trick today (thanks to @markusthoemmes ):

If you have a big interface to implement but only call a few functions, you can define the struct like this:

type mock struct {
  my.Interface
}

It'll implement all functions with nil-pointer function calls. Then you only have to implement the functions your test actually calls

This might be helpful if you only need to instgal some of the methods (like service create or update)

from client.

sixolet avatar sixolet commented on July 21, 2024

Considerations:

  • Downloading the right objects from etcd to a directory for the first time may another gitops usecase.
  • Anything that reads status and uses that information becomes harder or impossible (ex, locking revisions to a container digest)
  • Keeping only the "interesting" fields might make the directory easier to use.

from client.

cppforlife avatar cppforlife commented on July 21, 2024

Let's have a mode where you can provide a directory instead of a server to connect to

im somewhat skeptical that this would be that useful if users are using gitops workflow (== more familiar with yamls). what commands do you think will benefit from this?

from client.

nimakaviani avatar nimakaviani commented on July 21, 2024

throwing this here since it was discussed during today's call:

knative yaml generator
https://github.com/julz/knightrider

from client.

github-actions avatar github-actions commented on July 21, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

from client.

itsmurugappan avatar itsmurugappan commented on July 21, 2024

/remove-lifecycle stale
/assign

from client.

itsmurugappan avatar itsmurugappan commented on July 21, 2024

@rhuss @navidshaikh i think this is the issue we discussed in the last wg. For implementing this am planning to take the below approach, please let me know if this is good

  • Implement knclientinterface to work on local directory
  • change this line in all commands to return the appropriate client based on cmd flags
    client, err := p.NewServingClient(namespace)

from client.

rhuss avatar rhuss commented on July 21, 2024

(sorry closed by accident)

from client.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.