Reconcile Broad permissions for eallred

[knative]

Reconcile Broad permissions for eallred

[mattmoor]

I've created a temporary "team" for Eric and Paul under Knative Admins here: https://github.com/orgs/knative/teams/tbd-admins

[vaikas]

@eallred-google
@paulrossman

Are there any reasons for y'all to still have this level of access? I'd like to make headway on this old issue and this feels like this is no longer necessary. Could you please lmk if this is the case?

[vaikas]

And actually I hit send a little bit too soon. The group only contains @eallred-google.

[eallred-google]

Feel free to remove me. With gratitude, Eric

…

On Fri, Jan 29, 2021 at 2:07 AM Ville Aikas ***@***.***> wrote: And actually I hit send a little bit too soon. The group only contains @eallred-google <https://github.com/eallred-google>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#91 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALR6L2Z6VJYNYNGU2ZVP4IDS4KCE5ANCNFSM4KTGWWYQ> .

-- *Eric Allred* [email protected] Technical Program Manager Cloud Programs - Serverless

[mattmoor]

Thanks, @eallred-google

[mattmoor]

I sent a (linked) PR for @vaikas to stamp dropping the group and the admins: entry.

[vaikas]

Thanks @eallred-google PR has been stamped.

[vaikas]

Is something not working correctly or am I just holding things wrong?
I still see this group here in github:
https://github.com/orgs/knative/teams/tbd-admins

And @eallred-google is still a member and tbd-admins is still a member of knative-admin:
https://github.com/orgs/knative/teams/knative-admin/teams

@mattmoor hold up, wait a minute, something ain't right? Or is it?

[mattmoor]

Maybe Peribolos doesn't delete teams? 🤔

/assign @chizhg @evankanderson

[vaikas]

Ok, so looks like this might be an issue. Went looking for the peribolos jobs logs here:
https://prow.knative.dev/view/gs/knative-prow/logs/post-knative-peribolos/1357247051569565696

{"component":"unset","file":"prow/flagutil/github.go:75","func":"k8s.io/test-infra/prow/flagutil.(*GitHubOptions).Validate","level":"warning","msg":"It doesn't look like you are using ghproxy to cache API calls to GitHub! This has become a required component of Prow and other components will soon be allowed to add features that may rapidly consume API ratelimit without caching. Starting May 1, 2020 use Prow components without ghproxy at your own risk! https://github.com/kubernetes/test-infra/tree/master/ghproxy#ghproxy","severity":"warning","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"Throttle(1200, 100)","severity":"info","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"GetOrg(knative)","severity":"info","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"ListOrgInvitations(knative)","severity":"info","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"User()","severity":"info","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"ListOrgMembers(knative, admin)","severity":"info","time":"2021-02-04T08:38:13Z"}
{"client":"github","component":"unset","file":"prow/github/client.go:594","func":"k8s.io/test-infra/prow/github.(*client).log","level":"info","msg":"ListOrgMembers(knative, member)","severity":"info","time":"2021-02-04T08:38:13Z"}
{"component":"unset","file":"prow/cmd/peribolos/main.go:202","func":"main.main","level":"fatal","msg":"Configuration failed: failed to configure knative members: all team members/maintainers must also be org members: eallred-google","severity":"fatal","time":"2021-02-04T08:38:16Z"}

[vaikas]

Ok, after digging at this, peribolos was silently failing, created an issue for that in test-infra.
Verified that this team has now been removed:
https://github.com/orgs/knative/teams/tbd-admins