Giter Site home page Giter Site logo

Comments (6)

samodell avatar samodell commented on May 27, 2024

I think it's a nice idea, but I think we lose a lot of the safety and predictability of using Netlify, as well as a lot of the work Richie has done to hook up Netlify to Github, where we see automatic staging builds in the website repo.

It also sounds like a fair amount of work for a small tangible benefit -- most folks are not going to care what backend we run the site on. Right now, it is a bit difficult to set up local builds of Netlify, but it's also true that a pretty small number of people are interested in doing that.

from website.

RichieEscarez avatar RichieEscarez commented on May 27, 2024

I like it and I'm very much open to the idea but I need to think about this more.

Does porting over functionality include GitHub PR integration (ie. build staged draft for preview and also publish new merged content)? As Sam touches on, I'd hate to see any regression from where we've gotten to but appreciate the fact that we would overall gain more control.

Thinking further out, who do you envision would own and maintain the Knative site host?

Regarding the local builds, I have a PR open to simplify that a bit (PR #62). This is only a baby step since you still need to install Hugo (and postcss) but after cloning both the docs and website repos, you just run scripts/localbuild.sh (and you get a local build that is similar to what happens on Netlify).

from website.

rgregg avatar rgregg commented on May 27, 2024

Netlify has been great for bootstrapping our website. As we get closer to GA, we need to be using Knative more in production ways, and this seems like a way to do that with great visibility (both in terms of usage and finding issues, since if the website breaks due to Knative we'll know pretty quickly). I'd love to see our website adopting more of the best practices that we're encouraging with Knative.

While my current state would be a regression from current behavior, it shouldn't be too difficult to pull in the rest of the work you've done. I just hadn't done it yet since I wanted to see if this approach would work at all. With Knative Eventing we can trigger a build on changes to any of the repos we pull content from (website, docs, and community), build using Tekton, and then deploy into Knative serving.

The real tangible benefit here is to Knative, further validating the pieces we're building, in production for one of the core use-cases (serving HTTP). Having a completely reproducible environment for building, testing, and deploying the website is a nice benefit as well.

I'm happy to work on this more if it seems interesting. Maybe we can find a pathway to where we can transition ownership to the engineerings, so the docs team can spend less time managing infrastructure?

from website.

samodell avatar samodell commented on May 27, 2024

Well, that I'd be in favor of! I thought this plan involved Richie maintaining the new Knative-based version of the site 😂

from website.

RichieEscarez avatar RichieEscarez commented on May 27, 2024

Sounds good to me too.

from website.

mattmoor avatar mattmoor commented on May 27, 2024

where we see automatic staging builds in the website repo.

FWIW I have this running against knative/docs PRs where it builds docs and website (HEAD) into a container image that runs on knative/serving using the local build as an entrypoint.

from website.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.