Giter Site home page Giter Site logo

Comments (5)

tgriesser avatar tgriesser commented on June 28, 2024

@neilk they're not quite the same... in the second example, deleteTile is called immediately, it either needs to return a function, or the then needs to take an anonymous function:

function deleteTile(tile) {
  return function() {
    return db('tilestofetch').where(tile).delete();
  };
}

or:

createTile()
  .then(function() {
     return deleteTile(tile)
  })

(I'm not sure if that is the issue, but it might be part of it).

from knex.

neilk avatar neilk commented on June 28, 2024

Ah. I guess I thought then() was smart enough to recognize another promise. Thanks!

from knex.

tgriesser avatar tgriesser commented on June 28, 2024

@neilk - it is, but in this case you're invoking it immediately... effectively turning it into a value rather than a handler function.

from knex.

neilk avatar neilk commented on June 28, 2024

Now I'm confused again. What makes db('tilestofetch').where(tile).delete() invoke immediately, without .exec() or .then() ?

from knex.

tgriesser avatar tgriesser commented on June 28, 2024

Sorry, I didn't mean that it'd invoke immediately, it's just that it's just an object, not a function, and the onFulfilled has to be a function (spec)... so if you returned a value from that function with a then method that hasn't been called yet it'd be coerced into a promise, but otherwise just tossing an object that could turn into promise into the onFulfilled slot wouldn't be expected behavior.

from knex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.