Giter Site home page Giter Site logo

Comments (5)

tgriesser avatar tgriesser commented on July 30, 2024

I could be wrong here, but I think you should be able to just say this.type = 'LEFT' inside the function there and it should work... I might need to document the stuff around joins a little better. Let me know if that doesn't seem to do it.

from knex.

kwhitley avatar kwhitley commented on July 30, 2024

Great that worked for that - thanks for the quick reply! Now is there any way to prevent the back tick escaping of the last param? I'm trying to match either a slug or numeric in this join..., but it's assuming the string is a column name instead.

from knex.

kwhitley avatar kwhitley commented on July 30, 2024

Nevermind, used

Knex.Raw('"' + slug + '"')

as the last param - worked like a champ. If you know a better way, I'm all ears!

from knex.

tgriesser avatar tgriesser commented on July 30, 2024

Yep, I think that'd be the best way to do it, glad you got it sorted... I'll make sure to go back and document that a little better.

from knex.

tbuchok avatar tbuchok commented on July 30, 2024

in case anyone else is like us and using an ancient version of knex -- we're on 0.5.16 👎 -- i wanted to add that @tgriesser's fix does work, but with one small tweak:

the property was this.joinType (not this.type) for us.

here's what we have in production:

qb
  .join('a', function() { 
    this.joinType = 'LEFT'; // woo!
    this.on('a.b_id', '=', 'b.id')
  })
// ... more stuff

from knex.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.