Giter Site home page Giter Site logo

Comments (3)

shalvah avatar shalvah commented on July 21, 2024

Sure, PR welcome. In general, I didn't go with the approach of using the Laravel container because I wanted it to be easily testable in isolation.

from scribe.

Peterragheb avatar Peterragheb commented on July 21, 2024

@shalvah here's the PR #822

Btw I think the localization can be improved a bit.

  • Allow lang file to be under locale folder
  • Translate Docs title & description
  • Translate hardcoded strings in blade files

let me know if you're okay with that and I'll work on a PR

from scribe.

shalvah avatar shalvah commented on July 21, 2024

If you can make it work while still making sense for the end user and not having too much maintenance overhead, sure 👍

from scribe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.