Comments (7)
No, koa-compose support sync calls. The problem here is next()
return a Promise. We need return Promise or include it in async function (had been included in test case).
The following one is use promise-based sync function.
it(`should throw if next() is called multiple times in non async function`, () => {
const stack = [];
stack.push((ctx, next) => {
return next().then(() => {
return next()
});
});
return compose(stack)({}).then(() => {
throw new Error('boom')
}, (err) => {
assert(/multiple times/.test(err.message))
})
});
from compose.
await compose(stack)({});
Here, await compose(stack)({})
is wrong.
from compose.
Yes, so it should caught in try catch, but it didn't.
from compose.
Try this await expect(compose(stack)({})).rejects.toThrowError('next() called multiple times');
?
@xyluet
from compose.
it(`should throw if next() is called multiple times in non async function`, async () => {
const stack = [];
stack.push((ctx, next) => {
next();
next();
});
await expect(compose(stack)({})).rejects.toThrowError('next() called multiple times');
});
I tried that before, it resolved to value, but still throw error in UnhandledPromiseRejectionWarning
expect(received).rejects.toThrowError()
Expected received Promise to reject, instead it resolved to value
undefined
from compose.
expect
doesn't return a promise, so the last example wouldn't work. koa-compose doesn't support sync calls, thus your last next()
occurs out of context and the throw isn't caught.
It's the same as doing
try {
Promise.reject()
} catch {
// nothing to catch, nothing thrown yet
}
from compose.
@Runrioter that's exactly what I ment (I maybe expressed it badly). If you're dealing with them as promises the request chain isn't synchronous, the execute on a new tick.
from compose.
Related Issues (20)
- If `fn` is an asynchronous function, this `try catch` will be useless οΌ HOT 2
- I found that some code in the source code like `Promise.reject(),Promise.resolve()` seems redundant HOT 1
- Behavior changes on 4.2.0 HOT 5
- Add debug logs before and after each middleware executes HOT 1
- License is not included
- I donβt understand how the error is thrown when I find that next is called repeatedly. HOT 2
- Why use Promise.resolve() to wrap the execution results of each middleware? HOT 2
- Abnormal middleware errors occurred and KOA could not catch error events. How about the following changes
- [Question/Proposal] Sync/Async execution HOT 1
- Set default branch to next, default npm release to v3 HOT 1
- guard against unhandled next()s in development HOT 15
- Reorganize tests, and switch to Jest HOT 5
- when i use koa-compose with koa-router, koa-router does not work. HOT 6
- [Q&A] About Promise in the source code. HOT 1
- Outdated yield tests
- I can't catch the error ~ HOT 6
- Can't use destructuring with async await. HOT 2
- Unit test to verify if it handles wrapped non-async functions is wrong. HOT 1
- Control passed to handler before completing middleware chain HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from compose.