Comments (2)
Personally I think it is always advisable to use "${var:?}".
Put this case:
STEAMROT=$HOME/.local/share/Steam
rm -rf "$STEAMROOT/"*
In this example there is a missing letter in the variable declaration, and this cause the second commands to wipe all your files.
from shellcheck.
There's definitely a case to be made for safe habits. SC2086 has a corresponding optional/"strict" check, SC2248. Potentially, an optional version of this check could be useful, as well? I do think it would be nice to take advantage of the extra information by default.
In the end, I certainly don't feel that the current behavior is bad, simply that it could perhaps be refined. This issue is really just the result of having been surprised by SC2115's behavior compared to SC2086. 🙂
As for the typo, that would still trigger SC2034 for the unused variable and SC2153 for the undefined variable, both of which I feel are more relevant to having made a typo than not knowing whether the misspelled variable is empty.
from shellcheck.
Related Issues (20)
- SC2094, SC2035, SC2034, SC2205, SC2283 ternary arithmetic false positives
- RFE: variant of `source=` directive that supports globbing
- SC1090 is sometimes not raised HOT 1
- [Feature request][Bash] Add rules to provide tips on adding local, or readonly status to variables
- If multiple `source` lines are in the same file, all but the first one are ignored
- SC2320 warning in function
- ShellCheck warning SC2320 triggered incorrectly in function arguments HOT 1
- Missing documentation HOT 1
- Bad advice, strange mapfile behaviour HOT 3
- ShellCheck does not recommend quote variables HOT 5
- Coalesce quotes with `shellcheck -p diff`
- Report spam in the wiki HOT 2
- Busybox sh and glob matching HOT 1
- ksh: Unexpected failure when using functions in arithmetic expressions
- SC1091 after checking that file exists HOT 1
- Wrong format string variables count
- shellcheck fails to parse tests when the comparator is a variable.
- SC2164 HOT 2
- Associative array assignment with quoted keys triggers SC2079 HOT 1
- Writeable directory test passes with undefined variable HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shellcheck.