Giter Site home page Giter Site logo

Comments (4)

koaning avatar koaning commented on August 10, 2024 1

Feel free to make a PR. It might make sense to have the actual reference to the torch object to be self._device if that makes the __repr__ look better.

from embetter.

koaning avatar koaning commented on August 10, 2024 1

There's no harm in adding 'self.path' I think. Feel free to make that PR as well!

from embetter.

CarloLepelaars avatar CarloLepelaars commented on August 10, 2024

Cool! I made PR #34 which solves this and adds some tests for SentenceEncoder. Defining self._device additionally does not seem necessary as __repr__ output is already clean.

As for testing text embedders it looks like Sense2VecEncoder is a lot harder to test since it depends on loading a file from disk. Any ideas to test that or do you think its not necessary?

from embetter.

CarloLepelaars avatar CarloLepelaars commented on August 10, 2024

There's no harm in adding 'self.path' I think. Feel free to make that PR as well!

Cool! Created #35 for the Sense2Vec attribute fix.

from embetter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.