Error messages using `Object.entries` and `Object.values`

[waldyrious]

Error messages using `Object.entries` and `Object.values`

[koblas]

Did a bit better -- there is a small compatibility layer in there, still no external dependancies.

[koblas]

Make sure that you have "lib": ["es2017", "es2016"] in your tsconfig.json

Though If you're editing the project itself, it should have picked that up...?

[waldyrious]

The project I tried this in is not a typescript project, so it doesn't have a tsconfig.json file. Should I add one to the project directory even though it's not itself a typescript project?

Or should I just ignore those warnings? They only came up because vscode opened the bbanStructure.ts file when I was testing the lib in debug mode with auto-break on all exceptions, and tested with a malformed IBAN; once the file was open, vscode automatically performed checks in it and displayed those errors.

I then manually opened all the files in the ibankit project (inside my project's node_modules) just to make this report more complete. I guess as a downstream user I should ignore those errors, then?

[koblas]

Ugh - just learned something. TypeScript by default doesn't include the polyfills that are I'm using.

Options:

1. Convince me to write the code without using Object.entries() or Object.values()
2. Import core-js and the or the polyfill of your choice
3. Have me bake into the system a polyfill (still like the idea of 0 external dependencies)

[waldyrious]

I don't think Option 2 leads to a good experience in usage of this package. IMO the less friction and manual steps there are, the more likely people are to start and continue using it.

Between options 1 and 3, it ends up being a choice between the neatness of zero-dependencies and the neatness of newer ES syntax -- so it's a subjective choice that you're the most qualified person to make.

I would personally go with the latter (i.e. option 3), especially since the support for older ES syntax can be dropped once its prevalence becomes sufficiently low among JS engines, thus returning the package to the zero-dependencies status. WDYT?