Giter Site home page Giter Site logo

Comments (6)

SimonN avatar SimonN commented on August 16, 2024 1

@Rondom: I'm working on cleaning header defines. Among this, I'll move the above 4 macros to internal/dumb.h, and include that file in any .c that acts up.

Expect a PR within a day. :-) Everybody will be cordially invited to scrutinize.

from dumb.

kode54 avatar kode54 commented on August 16, 2024 1

I already moved them to internal, and included internal/dumb.h where they are used and it wasn't already included.

from dumb.

SimonN avatar SimonN commented on August 16, 2024 1

Even better, thanks! Just got your commit and looks good.

from dumb.

SimonN avatar SimonN commented on August 16, 2024

I'd remove these macros for 2.0. They don't seem to be used within DUMB, and callers would be surprised about the redefinition.~~

from dumb.

SimonN avatar SimonN commented on August 16, 2024

Correction: They are used inside DUMB. Thus, yes, should make them internal.

from dumb.

Rondom avatar Rondom commented on August 16, 2024

6e924e6 fixed this.

from dumb.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.