Comments (6)
@Rondom: I'm working on cleaning header defines. Among this, I'll move the above 4 macros to internal/dumb.h
, and include that file in any .c
that acts up.
Expect a PR within a day. :-) Everybody will be cordially invited to scrutinize.
from dumb.
I already moved them to internal, and included internal/dumb.h where they are used and it wasn't already included.
from dumb.
Even better, thanks! Just got your commit and looks good.
from dumb.
I'd remove these macros for 2.0. They don't seem to be used within DUMB, and callers would be surprised about the redefinition.~~
from dumb.
Correction: They are used inside DUMB. Thus, yes, should make them internal.
from dumb.
6e924e6 fixed this.
from dumb.
Related Issues (20)
- 0.9.3 -> 2.0 transition and 2.0 API shortcomings: document these HOT 2
- Can't Use DUMB_OFF_T_CUSTOM to Fix Static Assertion On 32-Bit System HOT 7
- Won't Compile with MinGW32 HOT 6
- Resamplers Crash When SSE Enabled (MinGW) HOT 7
- PSM Playback Has Garbled Sound HOT 1
- Compilation error with custom Allegro 4 include dir HOT 7
- aldumb missing HOT 11
- Ode to Protracker, 20sec, volume HOT 3
- libaldmb: Crashes with games that are using packfiles HOT 8
- Consider versioned dumb variants HOT 1
- Dumb can't open the UMX files included in the Unreal Beta of 1998 HOT 1
- Duplicate filenames on the playlist HOT 9
- Feature request: allow client code to programmatically set the next pattern. HOT 2
- Reads past end of file with DUMB_MOD_RESTRICT_OLD_PATTERN_COUNT HOT 3
- fb2k crashes while playing "ASIKWUSpulse - Shrubbing.s3m" HOT 2
- Support Standalone MIDI
- Seeking HOT 1
- allegro-5.2.5.0 HOT 1
- build fail HOT 1
- omit if-before-free
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dumb.