Giter Site home page Giter Site logo

Comments (4)

crtrott avatar crtrott commented on May 25, 2024

I think we should get rid of the MPI part. Kokkos Kernels is not supposed to know about MPI.

from kokkos-kernels.

mhoemmen avatar mhoemmen commented on May 25, 2024

However, MV unit tests depend on Teuchos MPI. Are they supposed to move to Tpetra? They are the last bits before removing the Teuchos dependency.

Do they actually use MPI, or do they just take a comm? If the latter, we can get rid of that. If the former, we'll have to decide whether we want them to use MPI directly (and thus making KokkosKernels have an optional MPI dependency) or just strip out those tests.

from kokkos-kernels.

mndevec avatar mndevec commented on May 25, 2024

They create their own Comm. It should be easy to remove all Comm related stuff.
I wanted to bring to your attention as there won't be any test running MV with MPI, which I assumed the intended case. We can remove Teuchos Comm from those tests, but still we need to add tests with MPI to Tpetra.

from kokkos-kernels.

mhoemmen avatar mhoemmen commented on May 25, 2024

@mndevec wrote:

... but still we need to add tests with MPI to Tpetra.

Those tests exist, insofar as Tpetra tests CrsMatrix's sparse matrix-vector multiply. Thus, I think it's fair to remove the MPI dependency from those tests in KokkosKernels, if @crtrott agrees.

from kokkos-kernels.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.