Comments (4)
I think we should get rid of the MPI part. Kokkos Kernels is not supposed to know about MPI.
from kokkos-kernels.
However, MV unit tests depend on Teuchos MPI. Are they supposed to move to Tpetra? They are the last bits before removing the Teuchos dependency.
Do they actually use MPI, or do they just take a comm? If the latter, we can get rid of that. If the former, we'll have to decide whether we want them to use MPI directly (and thus making KokkosKernels have an optional MPI dependency) or just strip out those tests.
from kokkos-kernels.
They create their own Comm. It should be easy to remove all Comm related stuff.
I wanted to bring to your attention as there won't be any test running MV with MPI, which I assumed the intended case. We can remove Teuchos Comm from those tests, but still we need to add tests with MPI to Tpetra.
from kokkos-kernels.
@mndevec wrote:
... but still we need to add tests with MPI to Tpetra.
Those tests exist, insofar as Tpetra tests CrsMatrix's sparse matrix-vector multiply. Thus, I think it's fair to remove the MPI dependency from those tests in KokkosKernels, if @crtrott agrees.
from kokkos-kernels.
Related Issues (20)
- Unecessary wait in oneMKL SpMV for 2023.2 and up HOT 1
- Remove references to `KokkosKernels_LINALG_OPT_LEVEL`
- Make sure `KokkosKernels_ENABLED_COMPONENTS` list of valid options is complete
- Necessity of both `KokkosKernels_ENABLED_COMPONENTS` and `KokkosKernels_ENABLE_...`? HOT 6
- axpby introduced deep_copies when alpha,beta are scalars HOT 2
- HIP -O0 -g: spgemm producess incorrect entries
- Trilinos nightly failure, ifpack2: spiluk errors with too few arguments to function call HOT 1
- One-based-ness of coloring is undocumented HOT 1
- Trilinos nightly failure, tpetra: no matching function for call to 'spadd_symbolic' HOT 1
- `KokkosBlas::Impl::MV_Reciprocal_Generic`: `g++-12` internal compiler failure with `-O3 -march=skylake-avx512` HOT 3
- rocSPARSE 3.0.2 for ROCm 6.0 breaking changes HOT 3
- Nightly test failures with cusolver tpl enabled, Cuda.svd_* unit tests HOT 6
- Nightly test failures, Cuda.svd_* and MKL DGEMM HOT 5
- Nightly test failures, builds with gcc/8.3.0 as host compiler: cc1plus: error with KokkosSparse::Impl::Sequential::TrsvWrap<...>::divide HOT 3
- Trilinos nightly failure, Cuda+UVM build, ifpack2/stokhos/sacado interaction in Ifpack2_LocalSparseTriangularSolver_def
- Lapack cuda.gesv_double test failing
- SYCL/PVC: native spmv, spmv_mv fail for complex_double
- Intel/2023.1.0 OpenMP, Serial test failures on SPR HOT 6
- spmv follow on changes: enable/disable deprecated code
- Nightly test failures, Cuda with TPLs, float types, in spiluk HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kokkos-kernels.