Magma and cuBLAS incompatible in unit tests

[ndellingwood]

Magma and cuBLAS incompatible in unit tests

[ndellingwood]

This is the culprit region in the BatchedGemmHandle for the unit tests:

kokkos-kernels/batched/dense/src/KokkosBatched_HostLevel_Gemm_Handle.hpp

Lines 99 to 152 in cb824ca

	BatchedGemmHandle(int kernelAlgoType = BaseHeuristicAlgos::SQUARE,
	int teamSize = 0, int vecLength = 0)
	: BatchedKernelHandle(kernelAlgoType, teamSize, vecLength) {
	#if defined(KOKKOSKERNELS_ENABLE_TPL_CUBLAS)
	if (!_tplParamsSet && kernelAlgoType == GemmTplAlgos::CUBLAS) {
	static cublasHandle_t cublas_handle;
	_tplParamsSingleton.cublas_handle = &cublas_handle;
	_tplParamsSet = true;
	}
	#endif // CUBLAS
	#if defined(KOKKOSKERNELS_ENABLE_TPL_MAGMA)
	if (!_tplParamsSet && kernelAlgoType == GemmTplAlgos::MAGMA) {
	static magma_queue_t magma_queue;
	_tplParamsSingleton.magma_queue = &magma_queue;
	_tplParamsSet = true;
	}
	#endif // MAGMA
	};
	BatchedGemmHandle(bool tplParamsSet,
	int kernelAlgoType = BaseHeuristicAlgos::SQUARE,
	int teamSize = 0, int vecLength = 0)
	: BatchedKernelHandle(kernelAlgoType, teamSize, vecLength) {
	_tplParamsSet = tplParamsSet;
	};
	#if defined(KOKKOSKERNELS_ENABLE_TPL_CUBLAS)
	BatchedGemmHandle(cublasHandle_t &cublas_handle,
	int kernelAlgoType = BaseHeuristicAlgos::SQUARE,
	int teamSize = 0, int vecLength = 0)
	: BatchedGemmHandle(true, kernelAlgoType, teamSize, vecLength) {
	_tplParamsSingleton.cublas_handle = &cublas_handle;
	};
	#endif // CUBLAS
	#if defined(KOKKOSKERNELS_ENABLE_TPL_MAGMA)
	BatchedGemmHandle(magma_queue_t &magma_queue,
	int kernelAlgoType = BaseHeuristicAlgos::SQUARE,
	int teamSize = 0, int vecLength = 0)
	: BatchedGemmHandle(true, kernelAlgoType, teamSize, vecLength) {
	_tplParamsSingleton.magma_queue = &magma_queue;
	};
	#endif // MAGMA
	decltype(auto) get_tpl_params() {
	#if _kernelAlgoType == CUBLAS && defined(KOKKOSKERNELS_ENABLE_TPL_CUBLAS)
	return _tplParamsSingleton.cublas_handle;
	#elif _kernelAlgoType == MAGMA && defined(KOKKOSKERNELS_ENABLE_TPL_MAGMA)
	return _tplParamsSingleton.magma_queue;
	#else
	return this->BatchedKernelHandle::get_tpl_params();
	#endif
	}

[lucbv]

Thanks for catching this, we should go clean it up.
Setting up the build with MAGMA is going to be very helpful!

[ndellingwood]

Adding a note that #2181 has a temporary workaround in the unit test to allow compiling tests with both magma and cublas enabled. I think the BatchedGemmHandle will need some refactoring in order to remove the workaround