Huge Performance issues

[kolking]

Huge Performance issues

[kolking]

To ensure that the rating component does not encounter the performance issues mentioned earlier, I measured the rendering time using the react-native-performance package. I created two screens for comparison; both screens contain a FlatList with 500 items. The "reference screen" renders a static image in place of the rating, while the "measure screen" renders the rating component in every FlatList item. After testing, the average time to render was 24 milliseconds for the "reference screen" and 34 milliseconds for the "measure screen." I believe the 10-millisecond difference is not a significant issue. The code I used for this testing can be found in the test-performance branch.

Screen.Recording.mp4

[kolking]

Hello, thanks for writing the issue! It's not enough information to figure out what the problem could be. Is it happens in iOS or Android? Simulator or real device? Expo or bare? Any errors in the console? What navigation package used? How many items in the FlatList? What else are you rendering in the FlatList besides the rating?

[ImamJanjua]

I have created a development build using Expo and tested it on an actual Android device. For navigation purposes, I have implemented React Navigation. The screen features a list of 8 items, each representing a different doctor. Each item in the list includes the rendering of an image, name, doctor's type, numerical rating, and price.

Interestingly, I observed that navigating to the screen without the rating component results in a speed improvement of approximately 2 to 3 seconds compared to when the rating component is included. If necessary, I can provide a video demonstrating the performance difference.

[kolking]

Yes please. Also, try to set disabled=true for the rating component. Will that help or stays the same?

[ImamJanjua]

Its stays the same

[ImamJanjua]

please tell me when u got something

[kolking]

Sure, will let you know. Btw, could you provide the video demonstration you've mentioned above?

[ImamJanjua]

screen-20240116-161032.3.mp4

In the upper once, I am using your package and in the bottom once my own Implantation.

[kolking]

Hmm... To be honest, I don't see a big difference between top / bottom tiles in the video. I looks like there's approximately the same delay after pressing the tile to display the list. At least, I definitely don't see the 2-3 seconds delay that you've mentioned before.

[ImamJanjua]

Maybe its not 3 second but still very noticable. Especially for the user.

[kolking]

I've just published v1.2.0, could you try and check is it better or not? During testing please make sure you set disabled=true for the Rating component and please use "release" (not "debug") build.