Moving blocks (or Drag and Drop) + Undo seems squishy

[kommitters]

Moving blocks (or Drag and Drop) + Undo seems squishy

[christoph-kluge]

I've updated my local version and reverted the workaround. It seems that it's all good now. Closing here.

Thank you so much for the quick repsonse 🙏

[Marthox]

Greetings @christoph-kluge.

Thanks a lot for raising this issue, I'll check if maybe a fix related with the drag'n drop plugin (kommitters/editorjs-drag-drop#83) fix this issue already, if not I'll give it a look to see how we can fix this

[Marthox]

Ohh nice, thanks a lot for the update, I'll reopen the issue to keep working on a solution.

And again thanks a lot, I really appreciate it!

[Marthox]

Hey @christoph-kluge, hope you're doing great!

There's up a new release (v2.0.3) where I tested the case you sent to us in the sandbox, and for me it seems to be working smoothly, please let us know if it fix the problem

Thanks for your time! Best regards

[Marthox]

Hey @christoph-kluge, hope you doing well.

In the last release of the plugin (v2.0.2) there should be the solution for this issue, if it persists please let us know.

[christoph-kluge]

@MarthoxGT @juanhurtado10 I did a quick test and I'm still facing this issue.

    "editorjs-drag-drop": "^1.1.2",
    "editorjs-undo": "^2.0.2",

[christoph-kluge]

I was curious and created a sandbox scenario. It seems it is fixed as soon as I isolate the behavior in a sandbox.

https://codesandbox.io/s/editor-js-drag-and-drop-undo-xpnmk8

Will dig deeper to identify why it's failing in my project.

[Marthox]

That'll help us a lot @christoph-kluge, thank you a lot for the time you're putting into.

Maybe deleting your node_modules folder and creating them again (if you haven't done it yet) could fix the issue in your local.

We are going to be attentive to your updates.

Mealwhile I'm going to try to replicate the issue with less ideal scenarios to see if I can find something.

Best regards.

[christoph-kluge]

@MarthoxGT thanks. Much appreaciated 👍

After giving it second try I finally found the isssue. It seems related to tools where the "id" property is set. Here is a sandbox where the behavior is broken:

https://codesandbox.io/s/editor-js-drag-and-drop-undo-broken-kdhen2

Hope this helps :-)

[christoph-kluge]

I could validate that it works with dynamic data as soon as I remove the id property like this:

    undo.initialize([...normalizedInput.blocks].map(block => {
      if (block.hasOwnProperty('id')) {
        delete block.id
      }
      return block
    }));

I guess there's some magic or comparison related to the id?