Giter Site home page Giter Site logo

Comments (7)

nicolasgaviria avatar nicolasgaviria commented on July 17, 2024

Hi @Rathpanha, can you tell me the process you're performing to get this error? Also, can you make sure you're using the last version of the plugin?

Thanks in advance!

from editorjs-undo.

Rathpanha avatar Rathpanha commented on July 17, 2024

Hi @nicolasgaviria, I am using react. I need to destroy the editor instance to clear all bind events to the editor in componentWillUnmount. It's easy to reproduce the error, just call the editor destroy API like my code below:

image

One thing I noticed is that when I click go back button of the browser the registerChange() is not called, but when I click on another link in my project, registerChange() is called and cursed this error, because of the editor instance has already been destroyed.

from editorjs-undo.

nicolasgaviria avatar nicolasgaviria commented on July 17, 2024

@Rathpanha Thank you! I'll check it ASAP.

from editorjs-undo.

nicolasgaviria avatar nicolasgaviria commented on July 17, 2024

@Rathpanha Hey! So sorry for the delay, I've been incredibly busy last days. I just created a new branch with something I think can solve your issue. Can you please check it out and tell me if it works for you?

Thanks!

from editorjs-undo.

Rathpanha avatar Rathpanha commented on July 17, 2024

Hi @nicolasgaviria , I tested and problem is still there. I'll try to help you look into this error as well. :)

from editorjs-undo.

nicolasgaviria avatar nicolasgaviria commented on July 17, 2024

@Rathpanha Hey! @Jmzp just pushed to the branch, can you check if his solution works for you? Thanks!

from editorjs-undo.

Rathpanha avatar Rathpanha commented on July 17, 2024

@nicolasgaviria @Jmzp Thank you, this does fix the problem this time 👍 😀

from editorjs-undo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.