Portfolio requests block `marketmaker` when network connectivity is lost

[komodoplatform]

Portfolio requests block `marketmaker` when network connectivity is lost

[artemii235]

I need to try to reproduce it and debug to find what exactly cause the issue. Not sure if it can be properly resolved in existing marketmaker. I guess it might be better to set a timeout on client side and also increase portfolio calls interval. If there are a lot of ERC20 enabled it'll get long anyway.

[lukechilds]

I guess it might be better to set a timeout on client side

By client side do you mean in marketmaker or in the GUI?

[artemii235]

I mean GUI, but now I'm not sure if it can help - need to check how MM works in case of client stops the request before getting a response.

[lukechilds]

Yeah that's the problem, it blocks the entire marketmaker process for the duration of the request. So even if we just ignore it, any new requests we issue will be blocked for the same amount of time.

[artemii235]

I see, I will check what can be done.

[lukechilds]

Thanks, I appreciate it.

[artemii235]

There's no portfolio request in MM2 anymore, even if we add 1 it will be non-blocking.