Comments (2)
I can confirm the issue, on both PowerPC32 (BE) and MIPS32 (BE) with https://modarchive.org/index.php?request=view_by_moduleid&query=108484 .
The root cause here has less to do with the fact that PowerPC is big-endian, but with the fact that libmodplug is writing to const data in at least one of its loaders.
CSoundFile::ReadPSM
calls swap_PSMCHUNK(pfh);
in line 111, and then bails out in line 121. swap_PSMCHUNK()
modifies various header fields starting at offset 0 with bswapLE32()
in-place. In CSoundFile::Create()
, ReadPSM
is tried before ReadMOD
or ReadMT2
. In MOD, the song title is stored right at the beginning of the file, resulting the the byte-swapped song title getting read.
In the case of MT2, this apparently causes libmodplug to outright misdetect the files as MOD.
The PSM loader leaves the API user provided const file data modified in both, the success and the error path.
I have not reviewed libmodplug thoroughly to determine if there are cases like this in other loaders.
(I'm the libopenmpt maintainer, thus I have also some knowledge about the libmodplug source code.)
from libmodplug.
Many of the places in libmodplug is little-endian-centric, so it is very much
expected that things fail on big endian hosts.
The PSM loader leaves the API user provided const file data modified
Eww..
from libmodplug.
Related Issues (20)
- Crash when reading a specific file HOT 4
- Public Domain declaration has problems HOT 2
- Seeking to invalid position doesn't report failure
- Documentation? HOT 1
- Add support for MAD* files (MADH/MADfg/MADI/MADK) HOT 2
- AMF Player (ReadAMF?) can't play correctly .amf files from Cannon Fodder 2 soundtrack
- Midi music get wrong duration && wrong tone HOT 1
- Please publish a git tag for the 0.8.9.0 release HOT 1
- Having trouble looping sounds HOT 1
- Segmentation fault in mmreadUBYTE(MMFILE*) HOT 4
- Missing git version tags HOT 1
- 0.8.9.0: compile time warnings HOT 9
- release early, release often
- [Feature Request] Mugician and Future Composer support HOT 1
- unable to play some s3m file HOT 1
- How to convert a "Set Global Volume" mod function to ULT function? HOT 10
- S3M requires 6 bytes after last pattern before end of file HOT 1
- [Feature Request] PlaySID v2.2+ (AMIGA) sidtune support
- Enhancing libmodplug's playback support for MIDI files and other "instrument-free" music formats
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libmodplug.