Possible mistake with 'w' command getting IP

[hellresistor]

Possible mistake with 'w' command getting IP

[konstruktoid]

yeah, and that requires access to an external resource which I'm trying to avoid.

[konstruktoid]

Thanks for catching this, I believe it's fixed with f4a9c30

[hellresistor]

nop. Getting the Gateway IP ;)
machine IP: 192.168.52.128
getting ip: 192.168.52.1

for me just. why use sed ?!
ADMINIP="$(hostname -I)"

[konstruktoid]

https://github.com/konstruktoid/hardening/blob/master/ubuntu.sh#L50 is the correctly updated version.

can you run hostname -I | sed -E 's/\.[0-9]+ /.0\/24 /g'?
it's overkill, but it's a crude way to catch all local networks if w doesn't get anything useful

~$ hostname -I
10.0.2.15 
~$ hostname -I | sed -E 's/\.[0-9]+ /.0\/24 /g'
10.0.2.0/24 

[hellresistor]

After installation.. YES. you get right IP during installation. Getting 192.168.52.1

[hellresistor]

works with this line (I think we have this discussion before ?! no? )

USERIP="$(ip route get 8.8.8.8 | awk -F"src " 'NR==1{split($2,a," ");print a[1]}')"

[hellresistor]

Try this!
USERIP="$(hostname --all-ip-addresses)"

or this
USERIP="$(ip -o addr show up primary scope global | while read -r num dev fam addr rest; do echo ${addr%/*}; done)"

[konstruktoid]

https://manpages.ubuntu.com/manpages/focal/en/man1/hostname.1.html
-I, --all-ip-addresses

[hellresistor]

and about 2nd line?

[konstruktoid]

USERIP="$(ip -o addr show up primary scope global | while read -r num dev fam addr rest; do echo ${addr%/*}; done)"?
Overly complicated.

[hellresistor]

USERIP="$(ip -o addr show up primary scope global | while read -r num dev fam addr rest; do echo ${addr%/*}; done)"?
Overly complicated.

well. but does what is needed

[konstruktoid]

hostname -I | sed -E 's/\.[0-9]+ /.0\/24 /g' doesn't work?

[hellresistor]

like command "says"
will replace the ip to a subnet ip 192.168.1.0/24

[konstruktoid]

Yes, and that's the point, if we don't get a valid address from the w command, e.g. when installing locally, we'll allow the /24 subnet so we can administer the machine afterwards of ssh.

https://github.com/konstruktoid/hardening/blob/master/ubuntu.sh#L47-L51

    USERIP="$($WBIN -ih | awk '{print $3}' | head -n1)"

    if [[ "$USERIP" =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
      ADMINIP="$USERIP"
    else
      ADMINIP="$(hostname -I | sed -E 's/\.[0-9]+ /.0\/24 /g')"
    fi

[github-actions]

This issue is stale because it has been open 30 days with no activity, without any activity this will be closed in 5 days.