Giter Site home page Giter Site logo

Comments (6)

xsorifc28 avatar xsorifc28 commented on August 12, 2024 1

Changing the getPkg function to this should fix it:

const getPkg = (client, pkg, create = false) => {
  if (!((pkg || '').indexOf('.') != -1) && client[pkg] !== undefined) { 
    return client[pkg] 
  }

  if (((pkg || '').indexOf('.') != -1) && client[pkg] !== undefined) { 
    return client[pkg] 
  }
  
  const ls = pkg.split('.')
  let obj = client
  ls.forEach(function (name) {
    if (create) {
      obj[name] = obj[name] || {}
    }
    obj = obj[name]
  })
  console.log("obj is", obj)
  return obj
}

from grpc-dynamic-gateway.

konsumer avatar konsumer commented on August 12, 2024

Hmm, I think this would require recursive namespace resolution. I notice the struct protoc makes looks like this:

namespace test {
namespace stuff {
// ... services stuff, here
}  // namespace stuff
}  // namespace test

It be a bit of re-work, but it's doable. I'm short on time, right now, but I can look at this, later. In the meantime, feel free to PR, or just use flat (no dot) namespaces.

from grpc-dynamic-gateway.

konsumer avatar konsumer commented on August 12, 2024

I think this may also be related to this issue. I am going to take another look.

from grpc-dynamic-gateway.

konsumer avatar konsumer commented on August 12, 2024

Closing, as this should be fixed in new versions of grpcnode & grpc-dynamic-gateway.

from grpc-dynamic-gateway.

xsorifc28 avatar xsorifc28 commented on August 12, 2024

The issue does seem to be solved, however if I don't have a [dot] in the package name, it gives an undefined error..

from grpc-dynamic-gateway.

WoLfulus avatar WoLfulus commented on August 12, 2024

When this will be published?

from grpc-dynamic-gateway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.