Giter Site home page Giter Site logo

Comments (4)

koppen avatar koppen commented on August 16, 2024 5

Much appreciated, thanks for reporting this.

By the looks of things it seems that Redmine Github Hook isn't compatible with newer versions of Redmine. I don't think it has been tested on anything newer than the 2.x line, and especially the newer, Rails 5 based versions are likely not going to work.

The fix should be fairly simple, at least if the above error is the only problem; replacing skip_before_filter with skip_before_action should make things work, albeit in a non-backwards-compatible manner.

I'll see if I can find some time for this, but I promise no timeframe, so pull requests beating me to it are welcome.

from redmine_github_hook.

roman-yagodin avatar roman-yagodin commented on August 16, 2024 1

The plugin of version 2.2.0 (installed from gem) works fine with my Redmine v3.4.2 install on Rails v4.2.8, Ruby v2.3.1p112 (2016-04-26).

Note that according to http://www.redmine.org/projects/redmine/wiki/RedmineInstall, Redmine 3.4 should use Rails 4.2.

from redmine_github_hook.

koppen avatar koppen commented on August 16, 2024 1

Cool, thanks for the details, @roman-yagodin .

@petarjov, it looks like you are on the pre-release line (3.4.2.devel), which supposedly has been upgraded to use Rails 5.1 in preparation for Redmine 4.x.

It seems you should be fine if you use the released 3.4.2 version of Redmine.

from redmine_github_hook.

koppen avatar koppen commented on August 16, 2024

Closing due to lack of activity; presuming the issue has been fixed.

from redmine_github_hook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.