Crash when attempting to launch Advanced settings

[jonnyl2]

Crash when attempting to launch Advanced settings

[hugleo]

PS:

There are one more item in config that is defined with nil value:

NETWORK_PROXY = nil,

Will be affected as well.

[hugleo]

Maybe something messing with the config?

What the contents of defaults.custom.lua file?

[jonnyl2]

Indeed, I commented out the STARDICT line and that fixed it.

This is how the last 3 lines of defaults.custom.lua looked like before:

    },
    STARDICT_DATA_DIR = "/mnt/onboard/.adds/dict", 
}

Is this not the proper way to define a custom dictionary location? The dictionaries were loaded from there correctly. I don't remember when I last opened the Advanced settings -- it could have been months ago.

[hugleo]

Could you try like that?

STARDICT_DATA_DIR = /mnt/onboard/.adds/dict,

EDIT: That will even´t read

I'm looking at it...

[hius07]

When building the list of the default default values the program iterates over all key-values from defaults.lua.

koreader/frontend/apps/filemanager/filemanagersetdefaults.lua

Lines 37 to 45 in c345de5

	for k, v in pairs(ro_defaults) do
	self.state[k] = {
	idx = 1,
	value = v,
	custom = false,
	dirty = false,
	default_value = v,
	}
	end

But defaults.lua contains

koreader/defaults.lua

Line 196 in c345de5

STARDICT_DATA_DIR = nil,

Lua pairs skips keys with nil values, so when building the list of custom default values we got crash in line 47

koreader/frontend/apps/filemanager/filemanagersetdefaults.lua

Lines 46 to 49 in c345de5

	for k, v in pairs(rw_defaults) do
	self.state[k].value = v
	self.state[k].custom = true
	end

because self.state["STARDICT_DATA_DIR"] is nil.

[hugleo]

yes, but not exactly.

The problem is here with dofile: https://github.com/koreader/koreader/blob/master/frontend/luadefaults.lua#L46
dofile will not load STARDICT_DATA_DIR even if is explicit defined with nil value.

We use this var here: https://github.com/koreader/koreader/blob/master/frontend/apps/reader/modules/readerdictionary.lua#L110

I suggest change to STARDICT_DATA_DIR = false in defaults.lua, what do you think?

[Frenzie]

Shouldn't we have seen this 2 or more years ago already? What changed since?

[hugleo]

for reference: https://stackoverflow.com/questions/40441508/how-to-represent-nil-in-a-table or https://forums.solar2d.com/t/inserting-nil-into-table/327955/3

> t = {a = "1", STARDICT_DATA_DIR = nil, b = 2}
for key,_ in pairs(t) do
   print(key)
end
b
a
> 

[pazos]

Shouldn't we have seen this 2 or more years ago already? What changed since?

Four since f756a6a 🤔

TBH I didn't check advanced settings back then so it is probably broken since its inception.

[hugleo]

Shouldn't we have seen this 2 or more years ago already? What changed since?

Four since f756a6a 🤔

TBH I didn't check advanced settings back then so it is probably broken since its inception.

This one will not crash. Is since this: #9546 ;-)