Giter Site home page Giter Site logo

Comments (8)

koute avatar koute commented on July 17, 2024

If you can grab the logs it should tell you which one was triggered.

Anyhow, hmm.... if I had to guess then most likely it has triggered the second abort (the first one is very unlikely and something would have to go extremely wrong for it to trigger).

Now that I think about it that check actually might not be correct and doesn't really make sense since when the control is given to the landing pad the value of the stack pointer will be higher than the address of the slot where the return address was stored, so we're basically checking whenever we've clobbered the stack ourselves. I'll remove it and hopefully you won't see this crash anymore.

from not-perf.

koute avatar koute commented on July 17, 2024

I've pushed the fix on master; can you check if it works fine now?

from not-perf.

stoperro avatar stoperro commented on July 17, 2024

Thanks, we will check and update :)

from not-perf.

stoperro avatar stoperro commented on July 17, 2024

Almost tested, had hard time compiling from scratch. The key for me was to use rustup target add mips64-unknown-linux-gnuabi64 to install toolset (yes, different arch), previously tried some other commands in rust and failed... maybe this is obvious for rust developers though.

Also, readme.md mentions "Install at least Rust 1.31", so I literally used 1.31.0 afraid of what newer versions may bring, which fails on:

error[E0658]: `Self` struct constructors are unstable (see issue #51994)
   --> /home/stoper/.cargo/registry/src/github.com-1ecc6299db9ec823/rgb-0.8.14/src/alt.rs:111:9
    |
111 |         Self(self.0, a)
    |         ^^^^

   Compiling proc-maps v0.1.0 (/mnt/c/buildy/not-perf/proc-maps)
error: aborting due to previous error

Seems to work on current stable branch though.

from not-perf.

koute avatar koute commented on July 17, 2024

Yeah, I need to update (or probably just remove it outright) the version mentioned in the readme and probably improve the cross-compiling instructions.

In general you should always use the newest available stable version.

from not-perf.

koute avatar koute commented on July 17, 2024

@stoperro By the way, didn't I leave you with a script to compile all of this automatically? You might want to look around for it. (:

from not-perf.

stoperro avatar stoperro commented on July 17, 2024

Funny thing, I learned about that script 1 hour ago :) Certainly that would have been better approach.
Still, already compiled manually on my PC with our SDK, and likely said script is also proper.

from not-perf.

stoperro avatar stoperro commented on July 17, 2024

Took a while... but we finally were able to test it and the crash we had doesn't occur anymore after the fix 👍

from not-perf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.