Not compiling with newest version of dependencies

[bobbobbio]

Not compiling with newest version of dependencies

[eduardvercaemer]

For anyone trying to get around this you can try this in your Cargo.toml

wasm-bindgen = "=0.2.84"

[sdasda7777]

Jeez, I'm not pinned to a higher version, but why did I have to waste three hours debugging this?

[rdbisme]

Hello, downgrading wasm-bindgen is a no-go for me since I need to use the latest version of the Cloudflare workers rust runtime, and they pin to wasm-bindgen=0.2.86.

Is there another way of fixing this?

[Dampfwalze]

The suggestion by @eduardvercaemer does fix the compile error, but pinning wasm-bindgen has other undesired impacts for me and really should not be the solution to the problem.

I think I found the issue! It is within these lines (Exactly where the error points to):

stdweb/src/webcore/ffi/wasm_bindgen.rs

Lines 63 to 70 in 9b418d9

	extern "C" {
	fn wasm_bindgen_initialize(
	memory: JsValue,
	table: JsValue,
	alloc: &Closure< Fn( usize ) -> *mut u8 >,
	free: &Closure< Fn( *mut u8, usize ) >
	) -> JsValue;
	}

I couldn't make sense of the error, but I looked at the docs of the Closure struct. Interestingly, in the examples, it is always used with the dyn keyword, which makes sense. The fix looks like this:

Closure<dyn Fn(...) -> ...>

On line 75 and 76 there is a warning: trait objects without an explicit 'dyn' are deprecated. I guess historically, rust implicitly added the dyn keyword, but at some point that feature got removed... Probably for the better. But since this package does not receive any updates (for 5 years, FIVE YEARS!!!), it is full of similar deprecation warnings that are never fixed. This is just the first instance where it broke. I am not sure why it works when pinning wasm_bindgen though.

This crate really needs a general overhaul to fix all the warnings! It has thousands of dependents, it is crucial that this crate does not brake! @koute