Proper aggregating structure for suggestions

[kowainik]

Proper aggregating structure for suggestions

[sphaso]

@chshersh sorry, do you mean something like:

data Suggestion = Suggestion
    { suggestionLine : Line
    , suggestionFile : FilePath
    , suggestionChange : LineChange
    }

data LineChange = LineChange
    { lineChangeNew     :: Text
    , lineChangeComment :: Maybe Text  -- ^ Optional comment to the suggestion
    , lineChangeType :: ChangeType
    } deriving (Eq, Show)

?

[sphaso]

Perhaps it might make sense to have a "suggestion type" union type, so we know that if the suggestion is of type "delete line" every other suggestion on that line can be discarded?

[willbasky]

Does #3 suit?

[chshersh]

@nixorn Is working on the Config type for checks. So we can add one more field to the Suggestion data type with something like suggestionType :: SuggestionType and then we can implement Semigroup instance for Suggestion that will handle joining of suggestions for us.

Not in PR #3, in separate PR, we're just discussing the architecture here 🙂

[sphaso]

I'm implementing suggestionType in #14 , I have a doubt: Suggest currently does not have a line number, shouldn't it have one? how would we link a line number (input) with the suggestion otherwise? do you think it's better to have a Line type inside Suggest or just a suggestLineNumber field?

[chshersh]

@sphaso I think you can rename Suggest data type to LineChange (or better name) and also introduce new data type:

data Suggestion = Suggestion
    { suggestionLine :: Line
    , suggestionChange :: SuggestionChange
    }

[chshersh]

@sphaso This also looks valid 👍

[sphaso]

I've just pushed the types discussed above in #14