Giter Site home page Giter Site logo

Comments (4)

Jigar3 avatar Jigar3 commented on September 13, 2024 2

I have started working on it. Will submit a PR soon. πŸ˜€

from hit-on.

chshersh avatar chshersh commented on September 13, 2024

@Jigar3 hi! I wonder, do you still have plans on finish this issue? Otherwise we would like to proceed with it and finish soon πŸ™‚

from hit-on.

Jigar3 avatar Jigar3 commented on September 13, 2024
runFix :: Maybe Text -> IO ()
runFix = \case
    Nothing -> do
        "git" ["add", "."]
        "git" ["commit", "-m", "Fix after review"]
        runPush False
    Just msg -> do
        "git" ["add", "."]
        "git" ["commit", "-m "] ++ msg
        runPush False
Error:

β€’ Couldn't match expected type β€˜[a1]’ with actual type β€˜Text’
β€’ In the second argument of β€˜(++)’, namely β€˜msg’

I am getting this error and am not sure if its the correct approach. Could you guide me please πŸ˜…

from hit-on.

chshersh avatar chshersh commented on September 13, 2024

@Jigar3 The problem is in this line:

"git" ["commit", "-m "] ++ msg

You want to append msg to the list ["commit", "-m "] but instead you're appending it to function call "git" ["commit", "-m "]. What you want is something like:

"git" $ ["commit", "-m "] ++ [msg]

Or just

"git" ["commit", "-m ", msg]

Also you may notice some code duplication in your function. Instead of pattern-matching on Maybe on top level you can just construct message text from that Maybe Text and pass it to "git" inside list. I hope that helps!

from hit-on.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.