Comments (4)
I have started working on it. Will submit a PR soon. π
from hit-on.
@Jigar3 hi! I wonder, do you still have plans on finish this issue? Otherwise we would like to proceed with it and finish soon π
from hit-on.
runFix :: Maybe Text -> IO ()
runFix = \case
Nothing -> do
"git" ["add", "."]
"git" ["commit", "-m", "Fix after review"]
runPush False
Just msg -> do
"git" ["add", "."]
"git" ["commit", "-m "] ++ msg
runPush False
Error:
β’ Couldn't match expected type β[a1]β with actual type βTextβ
β’ In the second argument of β(++)β, namely βmsgβ
I am getting this error and am not sure if its the correct approach. Could you guide me please π
from hit-on.
@Jigar3 The problem is in this line:
"git" ["commit", "-m "] ++ msg
You want to append msg
to the list ["commit", "-m "]
but instead you're appending it to function call "git" ["commit", "-m "]
. What you want is something like:
"git" $ ["commit", "-m "] ++ [msg]
Or just
"git" ["commit", "-m ", msg]
Also you may notice some code duplication in your function. Instead of pattern-matching on Maybe
on top level you can just construct message text from that Maybe Text
and pass it to "git"
inside list. I hope that helps!
from hit-on.
Related Issues (20)
- [RFC] Assign labels to newly created issues
- [RFC] wip commits HOT 2
- [RFC] hit rename
- Add tests: commit msgs. and branch names
- [RFC] hit fork command
- Support GHC-8.10 HOT 3
- Update header_information/ in the library modules
- `hit milestones` command to get the list of open milestones
- Add newly created issues to milestones
- Populate labels for the 'hit pr' command
- Fix 'hit status' for relative file paths
- Use 'git stash push' and handle optional argument to 'hit stash' to stash individual files
- Add draft option to 'hit pr' HOT 1
- Add 'hit tag' commands
- Implement releases through GH Actions
- Add --color-moved to hit diff
- Is it possible to run .bat file from business central OnSaaS( .BAT file is located in user machine ) HOT 1
- Switch the default branch to 'main' HOT 1
- [RFC] Warn about suspicious files
- Migrate from REST API to GraphQL API
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hit-on.