Snake Case Field Option

[koxudaxi]

Snake Case Field Option

[FlorianLudwig]

I implemented this here:

https://github.com/FlorianLudwig/pdk8s/blob/master/pdk8s/gen_k8s.py#L59

By changing the name to camel_case and keeping the old name as alias.

[camerondavison]

Maybe I am off base here but I feel like this is doing the opposite of what I am exepcting.

        class Model(BaseModel):
            notification_type: Optional[str] = Field(
                None,
                alias="notificationType",
            )
        self.assertEqual("{\"notification_type\": \"test\"}", Model(notificationType='test').json())

where I was expecting to have

self.assertEqual("{\"notificationType\": \"test\"}", Model(notification_type='test').json())

Since javascript and json is usually camel case, and python is usually snake case.

EDIT: reading through pydantic/pydantic#565
it looks like pydantic is taking the approach that the constructor is taking in the camel case version. It is still odd that the json does not return the public verions.

[koxudaxi]

@FlorianLudwig
Thank you for reviewing the PR.

I have released the version as 0.5.21 🎉

[camerondavison]

It looks like adding

    class Config:
        allow_population_by_field_name = True

and the whenever generating the json doing .dict(by_alias=True) works more like I was hoping. Is there a way to add pydantic config options to the generated classes?

[koxudaxi]

@camerondavison
The code-generator can't add a custom config.
But, I prefer to generate custom configs.
I will implement it.
Thank you.

[koxudaxi]

@camerondavison
I added an option for allow_population_by_field_name
It's included in version 0.5.33