Giter Site home page Giter Site logo

MSRV? about usync HOT 4 CLOSED

palfrey avatar palfrey commented on May 18, 2024
MSRV?

from usync.

Comments (4)

kprotty avatar kprotty commented on May 18, 2024

Not sure. How would one go about figuring this out? It requires std::arch::asm stabilization for x86 targets if that helps.

from usync.

palfrey avatar palfrey commented on May 18, 2024

Uh, there's probably more sophisticated ways to do so, but for serial_test I mostly just tested with various Rust versions, and then added a CI check to make sure the declared MSRV still kept working.

Although https://doc.rust-lang.org/stable/core/arch/macro.asm.html does say 1.59.0, so that's probably a good place to start :)

from usync.

thomcc avatar thomcc commented on May 18, 2024

Hm, 1.59.0 builds fine. It seems to reliably cause a double-panic issue in the test suite that I thought had only shown up under sanitizers, though.

That probably is just an issue with the test, and not something that impacts actual usage, although I can't say that with total certainty.

from usync.

palfrey avatar palfrey commented on May 18, 2024

#11 adds a test/badge for 1.59.0, but I'm also seeing a test issue locally.

from usync.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.