Comments (2)
It's true that fmt doesn't try to protect against cyclic data structures, but I think it's reasonable for pretty to be more defensive and to do something about it.
Maybe we should have a limit on depth of traversal.
If so, I guess there should also be a way for the caller to adjust the limit in cases where that's necessary. For example, maybe the default limit is 1000, and most callers never hit it. But if you have a cycle, it will prevent a crash. If you have a deeply nested non-cyclic structure and you want to print all of it, you can increase the limit. Or if you're in a resource-constrained environment, you can lower the limit.
But hopefully almost everyone would never have to adjust the limit or even know it exists.
from pretty.
Infinite recursion can also be triggered by self-referential data structures in "fmt" pkg, such as a slice that contains itself as an element, if that type has a String method. Such pathologies are rare, however, and the package does not protect against them.
from pretty.
Related Issues (20)
- Minor golint issues HOT 1
- Diff doesn't return difference b/w nil of slice and empty slice
- Set max depth HOT 1
- formatting of maps is invalid go code HOT 3
- Allow an option for 'deterministic' iteration order for map prints HOT 4
- Support fuzzy matching for floating point types
- type compare HOT 1
- Tag a release? HOT 2
- TestGoSyntax broken at v0.1.0 in Go 1.11
- Is there a way how I can skip zero values? HOT 1
- Go 1.15: conversion from int to string yields a string of one rune
- Request a new tagged release HOT 2
- PANIC=Format method: runtime error: invalid memory address or nil pointer dereference with go 1.17 HOT 8
- When I try to sync dependencies for this I get an error. HOT 2
- Expanded the print depth limit from 10 to 30.
- Go version is very old HOT 2
- Print uint in decimal? HOT 3
- false positive in cycle check
- Can non-nil interface fields be considered `nonzero`?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pretty.