Giter Site home page Giter Site logo

Comments (4)

roigcarlo avatar roigcarlo commented on May 18, 2024

@RiccardoRossi I am aware they are failing (the geometry ones). I will fixit asap.

from kratos.

roigcarlo avatar roigcarlo commented on May 18, 2024

@RiccardoRossi and @pooyan-dadvand
Regarding the TestTetrahedra3D4VolumeToSurfaceAreaQuality. This test is not implemented because we have no SurfaceArea() in the geometry.

I can remember having a discussion whether the Area() function should calculate this for 3D geometries or not.

Right now Area() is an alias for Volume() for 3D geometries and the other way around for 2D geometries.

Should I use Area() as SurfaceArea() in 3D ( and change its implementation) or should I make another different function?

from kratos.

RiccardoRossi avatar RiccardoRossi commented on May 18, 2024

Hi Carlos,

than this issue is closed?

from kratos.

roigcarlo avatar roigcarlo commented on May 18, 2024

Well the tests now check that they fail correctly, so I supose that we can close that, but maybe is a good idea to open another issue to so to remember that there are 2 implementations missing, or extend the current PTR that is fixing the problem with the volumeToLenght ratio

I'll do that tomorrow morning.

Anyway, it will be closed automatically when we merge #101

from kratos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.