Comments (11)
I tried to update with ng update, but results didn't look good.
@krausest did the update fail? Or the perf results weren't good? Happy to help, just trying to understand what is going on.
I guess it could be interesting to try the new nozone with the signals one as well
nozone for sure - and those are not tied to signals (I mean, you can run zoneless without using signals).
from js-framework-benchmark.
I guess it could be interesting to try the new nozone with the signals one as well
from js-framework-benchmark.
The update itself was fine. For angular-cf-signals I bootstrapped with provideExperimentalZonelessChangeDetection() and added ChangeDetectionStrategy.OnPush to the component.
After that select rows took 87 msecs instead of 6.5 msecs. Swap rows was similarly bad.
from js-framework-benchmark.
If it helps I set up a PR with my changes here: #1695
from js-framework-benchmark.
Those were the results I got. I can remove that image again if you want me to, since I really hope I made a silly mistake (left new keyed, right old keyed results):
from js-framework-benchmark.
Those were the results I got. I can remove that image again if you want me to, since I really hope I made a silly mistake (left new keyed, right old keyed results):
@krausest thnx for following up on this one. I will have a deeper but I don't see any "silly mistake" looking at the PR. What I do expect that the change detection scheduler we are using might not be playing nicely with the benchmark / way we measure. But yeh, this is just a suspicion for now, will profile!
from js-framework-benchmark.
@krausest actually I think I know what is going on - at least partly.
For angular-cf-signals I bootstrapped with provideExperimentalZonelessChangeDetection() and added ChangeDetectionStrategy.OnPush to the component.
After that select rows took 87 msecs instead of 6.5 msecs. Swap rows was similarly bad.
Looking at the change in https://github.com/krausest/js-framework-benchmark/pull/1695/files#diff-ede0fde54eaba73652ad146e9d60f72e603ed149428291a7a7fc83c3d667c26aR7 it would make running the change detection at least twice. The reason for this is that we've got now zoneless scheduling change detection and manual calls to detect changes.
from js-framework-benchmark.
I've removed double calls in a separate commit (see pkozlowski-opensource@307580b) and it significantly improves numbers but still performs worse as compared to the zone-based version.
The interesting thing is that under a profiler I can see select rows performing great so, as noted above, I think that our zoneless scheduler interact in an undesirable way with the benchmarking infrastructure. I didn't get to the bottom of it yet.
So I think we've got 2 issues:
- double calls to change detection (removed in pkozlowski-opensource@307580b)
- new zoneless scheduler and benchmarking
Given this I would suggest the following:
- revert switch to the experimental zoneless (left comments in a PR but can also prepare a patch commit) so we can compare evolution from one version to another;
- work on adding experimental zoneless to be benchmark in a separate PR
WDYT?
from js-framework-benchmark.
May I ask which is the latest modified PR? I would also like to participate and take a look
from js-framework-benchmark.
#1696 contains one new zoneless implementation.
The existing angular implementations were bumped to v18 in 40fc822 (without switching to new zoneless).
from js-framework-benchmark.
Those were the results I got. I can remove that image again if you want me to, since I really hope I made a silly mistake (left new keyed, right old keyed results):
If the test results of different devices have consistent standards
Perhaps this is a performance issue. Need Angular official to resolve it?
Because I feel like there's nothing more to optimize
from js-framework-benchmark.
Related Issues (20)
- Why does benchamrk `replaceAll` calls only `run`? HOT 1
- Eliminate "Advanced ad privacy" popup HOT 1
- chrome 124: weird results HOT 23
- Please pay attention to Nue.js HOT 4
- Make vanillajs score fastest on chrome 124 (again) HOT 32
- Feature request: Code complexity metric + Total # lines of code [maintained]
- Modify GC for chrome 125
- Feature request: page size 50|1000 HOT 1
- copy/paste selection doesn't appear to work HOT 2
- npm rebuild-ci with puppeteer hangs on VPS
- reatom? HOT 1
- Suppress "You can boomarks, reading mode, ..." popup HOT 3
- Chrome 126: New chrome, new errors HOT 1
- Flag unbundled/raw implementations HOT 2
- Hotwire HOT 2
- Add fast from Microsoft
- Update Svelte HOT 1
- No informative error running `npm start` if port 8080 is bound
- Update lwc to v7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from js-framework-benchmark.