Giter Site home page Giter Site logo

Comments (21)

patrick-fls avatar patrick-fls commented on May 4, 2024

@koistya Maybe replace it with Skeleton2?

from react-starter-kit.

dmnd avatar dmnd commented on May 4, 2024

fwiw I'd much rather just stick with bootstrap

from react-starter-kit.

hpaul avatar hpaul commented on May 4, 2024

Well, I think you should make it more customizable, so people could change Bootstrap with Foundation or Material UI or anything else.

from react-starter-kit.

buxel avatar buxel commented on May 4, 2024

i toyed with http://purecss.io/ for some time.
@koistya, are you planning to turn this in a yo generator? Otherwise, beside from being a lot of additional work for you anyways, supporting multiple frameworks might get quite messy.

from react-starter-kit.

yemi avatar yemi commented on May 4, 2024

The less opinionated the better. I would go for custom minimum basic styles since people most likely will use their css lib/framework/style of choice anyways.

from react-starter-kit.

oliverturner avatar oliverturner commented on May 4, 2024

The more dependencies on 3rd party libraries you include the harder it is to understand the structure and intent of the code. +1 on getting rid of Bootstrap in favour of a minimal custom stylesheet.

from react-starter-kit.

koistya avatar koistya commented on May 4, 2024

Spoiler: The CSS class names will follow this naming convention (BEM):

.ComponentName { }
.ComponentName--modifier { }
.ComponentName-elementName { }
.ComponentName-elementName--modifier { }

Which is well suited for modular architecture. No shared styles or images whatsoever. Only styles per component. BTW, the same CSS naming convention is currently used at Twitter.

from react-starter-kit.

oliverturner avatar oliverturner commented on May 4, 2024

@koistya going BEM strikes me as a good move and completely appropriate to React's strength in creating modular components.

We use a variant of the convention at Ticketmaster and have seen a massive reduction in side effects as a consequence.

from react-starter-kit.

sdiaz avatar sdiaz commented on May 4, 2024

It would be great, and what about BEM CSSO tool?

from react-starter-kit.

koistya avatar koistya commented on May 4, 2024

@sdiaz, it seems like CSSO project is abandoned. As of now, the starter kit is using autoprefixer, csscomb and clean-css. See gulpfile.js#L154-L156. I will make sure that these three are used after converting to stylesheet-per-component approach.

from react-starter-kit.

radum avatar radum commented on May 4, 2024

I agree with @yemi just remove it and people will use whatever they want.

from react-starter-kit.

seemsindie avatar seemsindie commented on May 4, 2024

I agree that it's should be less opinionated, let the people use whatever they want.

from react-starter-kit.

goatslacker avatar goatslacker commented on May 4, 2024

Bootstrap is good enough to provide as a base. FWIW this should all be easily pluggable.

from react-starter-kit.

ivanoats avatar ivanoats commented on May 4, 2024

πŸ‘ on making it easy to include other CSS frameworks like node-bourbon https://www.npmjs.com/package/node-bourbon

from react-starter-kit.

joybro avatar joybro commented on May 4, 2024

-1 for the following reasons.

  1. It is very useful for "starters" like me to have bootstrap as default.
  2. It would be not that hard for "experienced people" to remove or replace bootstrap.

from react-starter-kit.

koistya avatar koistya commented on May 4, 2024

A quote, from Web Starter Kit documentation, just replaced "Web Starter Kit" with "React Starter Kit":

React Starter Kit doesn't aim to compete with CSS libraries like Bootstrap, Foundation and Pure. These libraries provide an excellent solution for prototyping your initial project. The biggest challenge they present is it’s almost too easy to get stuck using their look and feel for the lifetime of your site. We think this leads to a poorer experience on the multi-screen web.

React Starter Kit provides boilerplate styles & a visual style guide for projects, but encourages customising these to fit your own site. This may need a little more work, but the reality is that any serious project is going to have its own look and feel. We want you to feel comfortable changing the kit to suit your own needs.

If you wish to use Bootstrap or other CSS libraries in your React Starter Kit project, you have the flexibility to do so.

Bootstrap is removed in c92ea26

from react-starter-kit.

kpnigalye avatar kpnigalye commented on May 4, 2024

Can anybody help me with integrating Zurb foundation with react starter kit?

I have installed foundation using 'npm install foundation'. I am not sure if this is correct.

from react-starter-kit.

koistya avatar koistya commented on May 4, 2024

@kpnigalye there easiest integration approach is to reference Zurb Foundation from a public CDN:

https://cdnjs.com/libraries/foundation

Just edit components/Html to include appropriate <link ../> tags. Do you think this approach will work for you?

from react-starter-kit.

ddewaele avatar ddewaele commented on May 4, 2024

Started looking into the react-starter kit since a couple of days and really impressed.

Also having some difficulties adding the bootstrap stylesheet. I tried the following.

  • App.scss

Added @import '../../../node_modules/bootstrap/dist/css/bootstrap.min.css' but got a failure during npm start.

  • Html component render function

Adding a link tag in the Html component.

<link rel="stylesheet" href="../../../node_modules/bootstrap/dist/css/bootstrap.min.css"/>

But it doesn't pickup the css file as it is not present in the build folder

  • Created public/css folder

Manually copied a bootstrap.css to the public/css folder and modified the copy.js script to also copy the css folder to the build folder.

The public/css folder thing works but feels like a hack. What would be the best way to add the bootstrap stylesheet ?

from react-starter-kit.

kpnigalye avatar kpnigalye commented on May 4, 2024

@koistya Yes I am following the same approach but how can I override foundation classes if I want to using sass?

from react-starter-kit.

pickingausername avatar pickingausername commented on May 4, 2024

@ddewaele Can you please give the whole config and details about implementing the bootstrap and .scss class names ?

Thanks

from react-starter-kit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.